Repository navigation
build: deduplicate sub-workspace downloader configs - #4467
Merged
rickeylev merged 1 commit intoNov 11, 2026
Merged
Conversation
Collaborator
Author
|
An AI coding agent assisted with authoring this pull request. The human author (@rickeylev) will review all feedback and either respond directly or review and approve any agent-assisted responses and changes before they are posted. This is an automatically generated agent comment. |
Maintaining 23 duplicate copies of `downloader_config.cfg` across example and integration test sub-workspaces adds file churn whenever mirror rules change. Delete the redundant sub-workspace `downloader_config.cfg` files and point each sub-workspace's `.bazelrc` to its parent module's `downloader_config.cfg` (`//:downloader_config.cfg`, `gazelle/downloader_config.cfg`, or `sphinxdocs/downloader_config.cfg`). Include `downloader_config.cfg` in `//:distribution` so `tests/integration` sandboxes can resolve it.
rickeylev
force-pushed
the
add_downloader_mirror_config
branch
from
November 11, 2026 01:34
f61e701 to
bc842fa
Compare
rickeylev
marked this pull request as ready for review
November 11, 2026 04:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintaining 23 duplicate copies of
downloader_config.cfgacrossexample and integration test sub-workspaces adds file churn whenever
mirror rules change.
Delete the redundant sub-workspace
downloader_config.cfgfiles andpoint each sub-workspace's
.bazelrcto its parent module'sdownloader_config.cfg(//:downloader_config.cfg,gazelle/downloader_config.cfg, orsphinxdocs/downloader_config.cfg). Includedownloader_config.cfgin
//:distributionsotests/integrationsandboxes can resolve it.