Skip to content

fix: list GitHub App installations instead of per-org lookups - #446

Merged
joshfriend merged 1 commit into
mainfrom
jfriend/list-app-installations
Nov 11, 2026
Merged

joshfriend merged 1 commit into
mainfrom
jfriend/list-app-installations

Conversation

@joshfriend

Copy link
Copy Markdown
Contributor

Orgs without an installation for the app repeated up to two installation lookups on every request before falling back to the fallback org token. That came to about 270k lookup_installation calls a day in production, most of cachew's GitHub API traffic.

Each app now lists its installations from /app/installations at startup and every five minutes, and lookups are answered from that set (case-insensitive). Orgs without an installation go straight to the fallback token with no API call. A failed refresh keeps the last known set. The rate-limit poller now covers every listed installation, and the api_calls metric reports list_installations instead of lookup_installation.

@joshfriend
joshfriend requested a review from a team as a code owner November 11, 2026 01:26
@joshfriend
joshfriend requested review from alecthomas and removed request for a team November 11, 2026 01:26
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-11T01:32:13.141925Z f50fd3b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Orgs without an installation repeated two lookup calls on every request.
@joshfriend
joshfriend force-pushed the jfriend/list-app-installations branch from a9991ff to f50fd3b Compare November 11, 2026 01:30
@joshfriend
joshfriend merged commit c2717cd into main Nov 11, 2026
7 checks passed
@joshfriend
joshfriend deleted the jfriend/list-app-installations branch November 11, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants