Skip to content

make GetRestPoseBoneTransforms agnostic to cmf/granny - #156

Merged
ccp-intern merged 1 commit into
mainfrom
fix-GetRestPoseBoneTransforms
Nov 16, 2026
Merged

ccp-intern merged 1 commit into
mainfrom
fix-GetRestPoseBoneTransforms

Conversation

@ccp-intern

Copy link
Copy Markdown
Member

https://fenriscreations.atlassian.net/browse/PLAT-12380

We know that the flickering is caused by the outdated math library. The default constructor of Matrix, called in this function GetRestPoseBoneTransforms, is not properly initializing the values in the old version of the library.

However, I suspect that GetRestPoseBoneTransforms could also cause more problems related to flickering. It only contained a cmf code path, and did not handle granny. I believe this could cause problems. when the following conditions hold:

  1. A .gr2 that binds more than one bone,
  2. A skinned shader, inherited from the parent’s overlay.
  3. No animation updater.

This pull request makes that function agnostic to cmf/granny.

There is an argument to be made that the function shouldn't exist at all. But that is a separate ticket, unrelated to the flickering. https://fenriscreations.atlassian.net/browse/PLAT-12293

@ccpisheden
ccpisheden requested a review from theagentd November 16, 2026 13:47
@ccpisheden
ccpisheden removed the request for review from theagentd November 16, 2026 13:48
@ccp-intern
ccp-intern merged commit ca75818 into main Nov 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants