Repository navigation
custom stencil missing - #157
Merged
Merged
Conversation
Ikreb1
requested review from
CCPNobody
and
a balanced review from Copilot
and removed request for
Copilot
November 16, 2026 14:24
Copilot stopped reviewing on behalf of
Ikreb1 due to an error
November 16, 2026 14:25
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the custom-stencil support restoration.
No open issues 🎉
What changed in this PR
Restores custom-stencil support after the render-driver refactor so outline effects can access the stencil during post-processing.
Changes:
- Retains the custom-stencil texture with the view’s render targets through post-processing.
- Binds the stencil for post-processing and clears the global binding afterward.
- Enables stencil allocation for the main view, while reflection views require an explicit named-output request.
| File | Description |
|---|---|
trinity/Eve/EveSpaceSceneRenderDriver.h |
Adds the stencil feature flag, retained texture, and updated allocation-helper signature. |
trinity/Eve/EveSpaceSceneRenderDriver.cpp |
Implements per-view allocation control, texture retention, and post-processing binding. |
Review effort: Balanced
olinord
approved these changes
Nov 16, 2026
…rontier anymore, re adding
Ikreb1
force-pushed
the
customstencil-re-add
branch
from
November 18, 2026 10:15
286ca20 to
18ede66
Compare
CCPNobody
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Custom stencil seems to not have lived the refactor of renderDriver reimplemented so outline effects work again in fontier
Linked issue (optional)
https://fenriscreations.atlassian.net/browse/EF-21380
Testing
local client trinitydev on PC
AI assistance
A little