Skip to content

custom stencil missing - #157

Merged
Ikreb1 merged 1 commit into
mainfrom
customstencil-re-add
Nov 18, 2026
Merged

Ikreb1 merged 1 commit into
mainfrom
customstencil-re-add

Conversation

@Ikreb1

@Ikreb1 Ikreb1 commented Nov 16, 2026

Copy link
Copy Markdown
Member

Summary

Custom stencil seems to not have lived the refactor of renderDriver reimplemented so outline effects work again in fontier

Linked issue (optional)

https://fenriscreations.atlassian.net/browse/EF-21380

Testing

local client trinitydev on PC

AI assistance

A little

@Ikreb1
Ikreb1 requested review from CCPNobody and a balanced review from Copilot and removed request for Copilot November 16, 2026 14:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the custom-stencil support restoration.

No open issues 🎉

What changed in this PR

Restores custom-stencil support after the render-driver refactor so outline effects can access the stencil during post-processing.

Changes:

  • Retains the custom-stencil texture with the view’s render targets through post-processing.
  • Binds the stencil for post-processing and clears the global binding afterward.
  • Enables stencil allocation for the main view, while reflection views require an explicit named-output request.
File Description
trinity/​Eve/​EveSpaceSceneRenderDriver.h Adds the stencil feature flag, retained texture, and updated allocation-helper signature.
trinity/​Eve/​EveSpaceSceneRenderDriver.cpp Implements per-view allocation control, texture retention, and post-processing binding.

Review effort: Balanced

@Ikreb1
Ikreb1 force-pushed the customstencil-re-add branch from 286ca20 to 18ede66 Compare November 18, 2026 10:15
@Ikreb1
Ikreb1 merged commit f28ed76 into main Nov 18, 2026
1 of 13 checks passed
@Ikreb1
Ikreb1 deleted the customstencil-re-add branch November 18, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants