Skip to content

Fix EveChildAudio objects not being able to be offset or rotated differently than their parent - #159

Draft
ccp-zoetrope wants to merge 1 commit into
mainfrom
fix/evechildaudio-world-transform
Draft

ccp-zoetrope wants to merge 1 commit into
mainfrom
fix/evechildaudio-world-transform

Conversation

@ccp-zoetrope

Copy link
Copy Markdown
Member

Summary

EveChildAudio had its own copy of m_worldTransform that was never updated, hiding the inherited one. This was removed because it was not possible to move an emitter anywhere but (0,0,0) on it's parent object.

  • Audio children now follow the object they are attached to, including any offset or rotation set on them or their parent containers.

Linked issue (optional)

Testing

Tested locally in Frontier where I was trying to place an EveChildAudio in the center of two objects using Python. Before this fix it would never move away from (0,0,0) and would keep its default rotation. After this fix it would correctly move where I told it to and would be rotated correctly as well.

AI assistance

Used to diagnose the problem and it pointed me at what to delete.

…erently than their parent

EveChildAudio had its own copy of m_worldTransform that was never updated, hiding the inherited one. This was removed because it was not possible to move an emitter anywhere but (0,0,0) on it's parent object.

- Audio children now follow the object they are attached to, including any offset or rotation set on them or their parent containers.
Copilot AI balanced review requested due to automatic review settings November 19, 2026 16:27

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the change to use the inherited world transform for audio emitters.

No open issues 🎉

What changed in this PR

Fixes EveChildAudio positioning and rotation by using the inherited world transform instead of a separate, stale copy.

Changes:

  • Removes the shadowing m_worldTransform member so audio emitters use the transform updated by their parent hierarchy.
  • Removes the corresponding constructor initializer.
File Description
trinity/​Eve/​SpaceObject/​Children/​EveChildAudio.h Removes the duplicate world-transform member.
trinity/​Eve/​SpaceObject/​Children/​EveChildAudio.cpp Removes initialization of the deleted member.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants