Skip to content

Fix missing pattern in .github manifest exclusion - #451

Open
Robolightning wants to merge 1 commit into
certifi:masterfrom
StableKite:codex/manifest-github-exclusion
Open

Robolightning wants to merge 1 commit into
certifi:masterfrom
StableKite:codex/manifest-github-exclusion

Conversation

@Robolightning

@Robolightning Robolightning commented Nov 12, 2026 •

Copy link
Copy Markdown

The recursive-exclude .github directive has no file pattern, so setuptools
reports 'recursive-exclude' expects <dir> <pattern1> <pattern2> ... and ignores
that directive when building the sdist. Add * to exclude the directory's files
as intended.

Validation with CPython 3.15.0 free-threading and setuptools 84.2.1:

  • Passing the original rule to setuptools' FileList.process_template_line
    raises DistutilsTemplateError; the corrected rule excludes a sample
    .github/workflows/ci.yml and preserves certifi/core.py.
  • python -m build --sdist --wheel --no-isolation succeeds before and after;
    the malformed-rule warning disappears after the change.
  • All wheel member names and contents are identical before and after. The
    sdist retains cacert.pem and py.typed and contains no .github files.
  • python -W error -m pytest: 3 passed.

This corrects a manifest warning and its ineffective exclusion; it does not
claim that the unmodified current release fails to build.

CI status: mypy and all Python 3.7–3.15 jobs pass. The
3.16-dev job
uses Python 3.16.0a2 and stops while importing pytest, before collecting any
certifi tests: pytest imports typing.AnyStr, whose new deprecation warning
becomes an error under -W error. The latest successful
master job
used Python 3.16.0a1 with pytest 9.2.0. I have left the workflow and its strict
warning policy unchanged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants