Repository navigation
#499 - process_launcher: a stopped process does not wait for the sub-processes - #500
Merged
Merged
Conversation
…processes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #499:
ProcessLauncherTask::flush()/next(): when the process has been stopped (ProcessHistory::isStopped(), set by aStopTask), the task no longer waits for the running sub-processes in its flush (skipped, flush mode left):finalize()stops them together (SIGTERM, thenSIGKILLafter 5 seconds, process_launcher: the sub-processes are stopped one after the other, up to 5 seconds each #459) and logs the warning, as documented;ProcessState::stop()withoutStopTask) does not stop the process: the flush still waits, as before;process_launcher_task.md.Checked locally: highest dependencies (PHP 8.5.12), with pcov coverage: all tests OK, no risky; PHPStan, PHP-CS-Fixer and Rector OK. In the demo project (pcntl), 4 sub-processes running
sleep 30and aStopTaskdownstream: 9 s and the warning "4 sub-process(es) still running ... have been stopped", 32 s without this PR.Requirements
Breaking changes
None: the documented behaviour.
🤖 Generated with Claude Code