Repository navigation
Conversation
Expanding 100 million entries with nodeset was very slow and consumed enough memory to make the CLI unusable. Replace the range-size assertion with a runtime check that rejects additions when the current set size plus the incoming index count reaches 100 million, accounting for the range step. Document the limit and add tests. Signed-off-by: Aurelien Degremont <aurelien.degremont@lelfe.net>
degremont
force-pushed
the
codex/issue-742-rangeset-limit
branch
from
November 17, 2026 17:53
074b466 to
04734b4
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanding 100 million entries with
nodesetcan be very slow and consume enough memory to make the CLI unusable.Replace the range-size assertion with a runtime check that rejects additions when the current RangeSet size plus the incoming index count reaches 100 million. The check accounts for the range step and conservatively counts overlapping indexes again. Document the limit in the class docstring and add library and CLI tests.
Validation: 298 relevant tests passed, plus four focused checks under
python -O.Fixes #742.