Repository navigation
docs(internal/examples): fix cd paths in chat and echo READMEs - #593
Merged
Merged
Conversation
2598ea2 moved the examples to internal/examples, but the chat and echo READMEs still told readers to cd examples/chat and examples/echo, which do not exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chat and echo READMEs tell readers to
cd examples/chatandcd examples/echo. Those directories moved tointernal/examplesin 2598ea2, so the commands fail. Both READMEs now use theinternal/examplespaths, and bothgo runcommands work from the repository root.