Repository navigation
docs(flutter): UI Kit ringing pages for v6.3.0 - #606
Conversation
Brings back the UI Kit calling docs from #564 that were held for the release in 08306dc, now that UI Kit 6.3.0 ships ringing through cometchat_voip: - Calling Integration page and its sidebar entry - Call Features, Incoming Call, Outgoing Call, Events, Methods, Color Resources, Getting Started, Theme Introduction, Troubleshooting and Upgrading from v5 sections - the CallListener warning on the Chat SDK Real-time Listeners page Checked against the v6.3.0 tag, cometchat_voip 2.0.0, Calls SDK 5.1.0 and Chat SDK 5.1.1: drops the release placeholders, says UI Kit 6.3.0 or later, and notes the Chat SDK calling APIs are deprecated since 5.1.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
jitvarpatil
left a comment
There was a problem hiding this comment.
🤖 Review Buddy (review-docs-pr)
Recommendation: approve. Automated review; the final decision stays with a maintainer.
TL;DR: The PR is structurally safe. No files are removed or renamed, so no redirects are needed. All navigation refs resolve, there are no broken internal links, and every cross-page anchor and image exists. I checked the content against the released packages: UI Kit v6.3.0 tag, cometchat_voip v2.0.0 tag, Chat SDK v5.1.1 tag, and pub.dev (cometchat_chat_uikit 6.3.0 and cometchat_voip 2.0.0 are both live). The documented APIs and colour defaults match the source. There are no P0 or P1 findings. Three P2 items concern the copy-paste snippets: they leave out guards that the UI Kit master app has.
P0: none
P1: none
P2: worth fixing
- The logout snippet can stop logout from running. See
ui-kit/flutter/calling-integration.mdx:260, and the same advice atmethods.mdx:99,troubleshooting.mdx:70andupgrading-from-v5.mdx:128.CometChatVoip.unregisterPushToken()throws when the device is offline, when no token was registered, or on web (unsupportedPlatform). The snippet awaits it with no try/catch, so in those casesCometChatUIKit.logoutnever runs and the user stays logged in. The v6.3.0 master app wraps the call (master_app/lib/screens/home_screen.dart:266-270,login_screen.dart:64-71) inif (!kIsWeb)plustry { … } catch (_) {}before logout. Mirror that. - The setup snippets have no web guard. See
calling-integration.mdx:63-86(Step 2),:203-239(Steps 5–6) and:259(Step 8). The page says web keeps Chat SDK ringing and doesn't usecallPushBridge. But the init, token and logout snippets callcometchat_voipwithout a guard, and on web those calls throw. A Flutter app that also targets web needsif (!kIsWeb), as the master app has. One sentence or a guard in each snippet is enough. Minor point in the same snippet: the Step 2onErrorswallows a Calls SDK init failure silently. The master app logs it. - The diagram label is ambiguous. See
calling-integration.mdx:21andcall-features.mdx:31.Call button → initiateCallsits on the same page that lists the Chat SDKinitiateCallas superseded (call-features.mdx:15). Label itCometChatCalls.initiateCallso readers don't reach for the deprecated Chat SDK method.
Verified ✅
- Redirects: 0 removed or renamed files, so 0 new 404s and 0 chained redirects.
- Build: 0 dangling nav refs. The new
ui-kit/flutter/calling-integrationentry resolves. - Links: 0 broken internal links across 62 scanned files. The anchors
/calls/flutter/voip-calling#step-2-initialize,#theming-the-ring-screen,#your-own-ring-screen,/ui-kit/flutter/events#call-events, the in-page#styling-the-ring-screenand#step-2-…anchors,/calls/flutter/ringingand/calls/flutter/migrating-from-legacy-ringingall resolve. - Images: the 3 referenced images exist on the branch.
- API accuracy:
- The
VoipCallPushBridgesnippet is identical tomaster_app/lib/notifications/services/voip_call_push_bridge.dart@ v6.3.0. CometChatCallPushBridge,CometChatPushCallandCometChatPushCallEndedare exported fromcometchat_calls_uikit.dart. Thereport*members have default bodies, so the "extend, don't implement" note is accurate.CometChatIncomingCallTheme.of/.from(light:, dark:, mode:)match the source. The dark-set fallback to the light palette is documented correctly.- All 11 ring screen fields and the light/dark default hex values in
color-resources.mdxmatch_colors()exactly. - The
cometchat_voip2.0.0 calls exist with the documented signatures:init,fromCallAppSettings(providerId:),handlePushNotification(sentTime:),registerPushToken(token:),handleTokenRefresh,checkRingReadiness/openSettings,setIncomingCallTheme,isInitialized,onCallAnswered/onCallEnded, andreason.wireName.
- The
- Behaviour claims:
- The 45 s outgoing timeout is in
active_call_tracker.dart:180. ccOutgoingCallfires on place, andccCallRejectedfires on cancel, timeout and logout.ccCallAcceptedfires only from the incoming-call bloc.- The barrels hide
CallListener/CallListener2. - Chat SDK 5.1.1 marks
addCallListener,initiateCall,acceptCall,rejectCallandendCall@Deprecated.
- The 45 s outgoing timeout is in
- Version consistency: every install snippet now pins
^6.3.0, with no 6.2.0 left in the changed pages. - Placeholders: the
TODO(RC)placeholders are gone. - Pre-existing, not from this PR:
ui-kit/flutter/llms-flutter-v6.mdxis not in navigation.
Skipped: I didn't render-check the Mintlify preview by hand. The bot reports the preview as 🟢 Ready.
jitvarpatil
left a comment
There was a problem hiding this comment.
✅ Approved via Review Buddy after an automated review (P0: 0 · P1: 0 · P2: 3).
Findings: #606 (review)
Description
Restores the Flutter UI Kit ringing docs from #564. Those pages were held back in 08306dc until the UI Kit release, and #586 brought back only the Calls SDK and push pages. UI Kit 6.3.0 now ships ringing through
cometchat_voip, so this puts the UI Kit side back.New page
ui-kit/flutter/calling-integration.mdx, Calling Integration: the full setup for ringing in the UI Kit. It covers dependencies, initializing the Calls SDK andcometchat_voip, theCometChatCallPushBridgeclass,enableCalls/callPushBridgeinUIKitSettings, handing call pushes tocometchat_voip, the push token, permissions and ring readiness, logout, styling the ring screen with the UI Kit theme, what the UI Kit handles from there, and upgrading fromCometChat.addCallListener.docs.jsonunder UI Kit > Flutter > Getting Started.Updated UI Kit pages
CometChatIncomingCallStyletoCometChatVoipIncomingCallColors.ccOutgoingCall,ccCallRejected).enableCalls,callingConfigurationandcallPushBridgeinUIKitSettings, and whatlogout()does with calls enabled.Chat SDK
sdk/flutter/real-time-listeners.mdx: restores the warning thatCallListener/CometChat.addCallListener()are superseded byCometChatCalls.addIncomingCallListener, and are deprecated since Chat SDK 5.1.1.Checked against the released packages: UI Kit
v6.3.0,cometchat_voip2.0.0, Calls SDK 5.1.0 and Chat SDK 5.1.1.cometchat_voipcalls, the UI Kit settings, the theme and its colour defaults, and the events table.TODO(RC)release placeholders.Related Issue(s)
Type of Change
Checklist
Additional Information
mainsince they were held, so nothing newer is overwritten.voip-calling.mdx's ring screen theme section, left out on purpose.OngoingCallServicemanifest entry, Swift Package Manager on iOS) isn't repeated here. See Calls > Background Handling and Setup.Screenshots (if applicable)
N/A. Text and table changes only. The one image, the Message Header call buttons on Calling Integration, already exists in
/images.