Repository navigation
fix: consolidate slot cleanup and add verified stop handling - #321
Merged
Merged
Conversation
- Move the local and remote pooled-copy clearing procedure into the cleanup skill; docs and the verification record now point at it. - Document the captain-approved remote removal route through fm-on, damaged-slot inventory evidence, and the limits of tracked-file comparisons. - Add a sweep stop marker honored between clean slots, with regression tests for unnamed, out-of-pool, and stopped removals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Evidence
--allwas the only remote route and remote pools were report-only; a running local--apply-cleanhad no stop path; the config document restated the sweep procedure; and there was no host measurement command.After: Remote removal is one exact captain-named path per
fm-oninvocation; local--stopis honored between clean slots;--measurereports existence, size, and tier through the same tracked command.tests/fm-treehouse-sweep.test.shpasses 14 checks, and the PR has 20 green checks.Merge Danger
Door: two-way
Blast Radius: Contained
The PR changes cleanup procedure and adds read-only measurement plus a local stop marker; it adds no automatic removal, and the existing
--apply-slotand--apply-cleanguards are unchanged.Testing
Targeted regressions and five real local CLI scenarios passed after correcting a disposable origin's default branch. Transcripts were retained and fixtures removed. Remote transport was not exercised; no real pools or second mates were contacted.
Evidence: Live CLI transcript
Evidence: Validation scope and independent oracle
Evidence: Targeted regression results
Pipeline
Updates from git push no-mistakes
✅ **Intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
🔧 **Review** - 3 issues found → auto-fixed ✅
.agents/skills/cleanup/SKILL.md:72- Requirement 2 permits remote removal “for exact captain-named paths only,” but this new remote --apply-clean route accepts no paths and inherits wholesale approval, allowing removal of every currently clean remote slot. It also cannot honor the advertised remote stop at SKILL.md:82: fm-remote-entrypoint.sh queues --stop behind the running sweep, and fm-remote-job-worker.sh:646 executes jobs synchronously; only delta reads are preemptible. All slots can therefore finish before the marker is written, violating AC4. Remove this unrequired remote bulk route and align the remote execution summary at SKILL.md:146 and stop guidance at :81–87 with the supported exact-path boundary; retaining bulk removal needs explicit authorization..agents/skills/cleanup/SKILL.md:89- The prescribed remote remeasurement cannot be performed through these commands. fm-on.sh accepts only tracked fm-*.sh executables, while fm-treehouse-sweep.sh:512–521 reports classifications and a prune dry run without path sizes or existence measurements. After partial deletion, this leaves the required fully/partly/untouched report at SKILL.md:88–91 without an executable measurement route. Document a supported read-only host command instead of requiring measurement through the same tracked commands.docs/configuration.md:272- The claim that an absent flag makes “every sweep pass” read-only is false: --apply-slot <dirty-path> --captain-approved still destroys the named slot without this flag, because the flag gates only --apply-clean. Narrow this statement to the clean-tier pass so the configuration documentation accurately describes the removal guard.🔧 Fix applied.
✅ Re-checked - no issues remain.
✅ **Test** - passed
✅ No issues found.
TMPDIR="$PWD/.test-cleanup-tmp" bash tests/fm-treehouse-sweep.test.shpython3 ~/.no-mistakes/evidence/01M7NZFAN2XXJZJ97847WKDAXF/live-cleanup.pyusing real Git and Treehouse v3.1.1Compared synthetic file hashes, path existence, and independentdu -skmeasurements.Awaited all subprocesses, removed disposable fixtures, and confirmed a clean working tree.✅ **Document** - passed
✅ No issues found.
🔧 **Lint** - 1 issue found → auto-fixed ✅
🔧 Fix applied.
✅ Re-checked - no issues remain.
✅ **Push** - passed
✅ No issues found.