Repository navigation
write-sha256sum: generate checksums in binary mode - #563
Merged
Merged
Conversation
Use `sha256sum --binary` when generating checksum files for static
archives, so the checksum explicitly indicates binary mode.
Before:
<sha256> docker-engine_29.10.0-rc.1.tgz
After:
<sha256> *docker-engine_29.10.0-rc.1.tgz
On Linux, both modes produce identical checksums, but the binary
marker is more appropriate for archives and avoids potential
text-mode conversion when verifying on other platforms.
updates 7d994c2
updates 810d7bd
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the explicit binary-mode archive checksum update.
No open issues 🎉
What changed in this PR
Updates static archive checksum generation to explicitly use binary mode, refining the checksum support introduced in #495.
Changes:
- Adds
--binarytosha256sum, producing checksum entries with a*binary marker while leaving hash values unchanged on Linux.
| File | Description |
|---|---|
hack/scripts/write-sha256sum.sh |
Generates archive checksum files with an explicit binary-mode marker. |
Review effort: Balanced
crazy-max
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related;
Use
sha256sum --binarywhen generating checksum files for static archives, so the checksum explicitly indicates binary mode.Before:
After:
On Linux, both modes produce identical checksums, but the binary marker is more appropriate for archives and avoids potential text-mode conversion when verifying on other platforms.
updates 7d994c2
updates 810d7bd