Skip to content

write-sha256sum: generate checksums in binary mode - #563

Merged
thaJeztah merged 1 commit into
docker:mainfrom
thaJeztah:binary_checksums
Nov 10, 2026
Merged

thaJeztah merged 1 commit into
docker:mainfrom
thaJeztah:binary_checksums

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

related;

Use sha256sum --binary when generating checksum files for static archives, so the checksum explicitly indicates binary mode.

Before:

<sha256>  docker-engine_29.10.0-rc.1.tgz

After:

<sha256> *docker-engine_29.10.0-rc.1.tgz

On Linux, both modes produce identical checksums, but the binary marker is more appropriate for archives and avoids potential text-mode conversion when verifying on other platforms.

updates 7d994c2
updates 810d7bd

Use `sha256sum --binary` when generating checksum files for static
archives, so the checksum explicitly indicates binary mode.

Before:

    <sha256>  docker-engine_29.10.0-rc.1.tgz

After:

    <sha256> *docker-engine_29.10.0-rc.1.tgz

On Linux, both modes produce identical checksums, but the binary
marker is more appropriate for archives and avoids potential
text-mode conversion when verifying on other platforms.

updates 7d994c2
updates 810d7bd

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the explicit binary-mode archive checksum update.

No open issues 🎉

What changed in this PR

Updates static archive checksum generation to explicitly use binary mode, refining the checksum support introduced in #495.

Changes:

  • Adds --binary to sha256sum, producing checksum entries with a * binary marker while leaving hash values unchanged on Linux.
File Description
hack/​scripts/​write-sha256sum.sh Generates archive checksum files with an explicit binary-mode marker.

Review effort: Balanced

@thaJeztah
thaJeztah merged commit b18497c into docker:main Nov 10, 2026
2227 of 2231 checks passed
@thaJeztah
thaJeztah deleted the binary_checksums branch November 10, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants