Repository navigation
Make dropdowns follow a language switch - #9
Merged
Merged
Conversation
…guage Reka's SelectValue copies the chosen option's text when it first draws and keeps it, so after a language switch four dropdowns went on showing the old language: the Audit entity filter, the Media type and sort filters, the language direction, and the product editor's category (category names are content, read again in the new language). Each now renders its value from the model, as the product category filter and the language picker already did. An e2e test switches to Arabic with the Audit entity filter on screen; it fails on the old code and passes now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After switching the reading language, four dropdowns kept showing their selected value in the previous language until the page was reloaded:
Why: Reka's
SelectValuecopies the chosen option's text when it first draws and keeps that copy; retranslating the options does not update it.Fix: each of these now renders its shown value from the selected value, as the product category filter and the language picker already did, so it follows the language. The page-size pickers show numbers only and are unchanged.
Verified
npm run lint,npm run typecheck,npm test(24),npm run test:e2e(14).🤖 Generated with Claude Code