Skip to content

Make dropdowns follow a language switch - #9

Merged
sadeqabuhattem merged 1 commit into
mainfrom
fix/dropdowns-follow-language
Nov 19, 2026
Merged

sadeqabuhattem merged 1 commit into
mainfrom
fix/dropdowns-follow-language

Conversation

@sadeqabuhattem

Copy link
Copy Markdown
Member

After switching the reading language, four dropdowns kept showing their selected value in the previous language until the page was reloaded:

  • the Audit entity filter ("Any entity")
  • the Media type and sort filters ("Any kind", "Newest first")
  • the language direction field in the language editor
  • the product editor's category (category names are content, read again in the new language)

Why: Reka's SelectValue copies the chosen option's text when it first draws and keeps that copy; retranslating the options does not update it.

Fix: each of these now renders its shown value from the selected value, as the product category filter and the language picker already did, so it follows the language. The page-size pickers show numbers only and are unchanged.

Verified

  • New e2e test: opens Audit, switches to Arabic, and expects the entity filter to read "أي كيان". It fails on the old code (still "Any entity") and passes now.
  • npm run lint, npm run typecheck, npm test (24), npm run test:e2e (14).
  • In the running sample: switching to Arabic on Media turns the filters into "أي نوع" and "الأحدث أولًا".

🤖 Generated with Claude Code

…guage

Reka's SelectValue copies the chosen option's text when it first draws and
keeps it, so after a language switch four dropdowns went on showing the old
language: the Audit entity filter, the Media type and sort filters, the
language direction, and the product editor's category (category names are
content, read again in the new language). Each now renders its value from
the model, as the product category filter and the language picker already
did.

An e2e test switches to Arabic with the Audit entity filter on screen; it
fails on the old code and passes now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sadeqabuhattem
sadeqabuhattem merged commit a428c38 into main Nov 19, 2026
2 checks passed
@sadeqabuhattem
sadeqabuhattem deleted the fix/dropdowns-follow-language branch November 19, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant