Skip to content

Report the HTTP method of a call to onCallActivity (0.14.3) - #79

Closed
velis74 wants to merge 1 commit into
mainfrom
call-event-method
Closed

velis74 wants to merge 1 commit into
mainfrom
call-event-method

Conversation

@velis74

@velis74 velis74 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

The start event of onCallActivity carries the call's HTTP method (CallEvent.method, optional). The REST and muxws proxies pass it as the new fourth argument of issueCall(promise, key, background, method).

Why: taskwire's busy indicator follows every proxy call that stays open longer than progressUi.delay and reads GET /taskwire/{key} for it. A server never tracks a GET (TW-CALL-002), so on a slow connection each of those reads is a wasted round trip. With method, taskwire can leave such calls out.

  • Docs: docs/api/idempotency.md, docs/guide/idempotency.md.
  • Version 0.14.3 (Python and npm).

The start event carries the call's method, so a busy indicator can leave out calls a server does not track by method, such as a GET.
@github-actions

Copy link
Copy Markdown

✅ Incremental coverage — 100%

████████████████████ 3 / 3 changed lines covered · threshold 70% · main → call-event-method

File Coverage Covered Uncovered lines
✅ vue/call.ts 100% 1 / 1 —
✅ vue/muxws-proxy.ts 100% 1 / 1 —
✅ vue/rest-proxy.ts 100% 1 / 1 —
Total 100% 3 / 3
9 files not graded (2 ignored by pattern, 7 not source files)
File Reason
changelog.md not a source file
docs/api/idempotency.md not a source file
docs/guide/idempotency.md not a source file
package-lock.json not a source file
package.json not a source file
pyproject.toml not a source file
uv.lock not a source file
vue/muxws-proxy.spec.ts ignored by *.spec.*
vue/rest-proxy.spec.ts ignored by *.spec.*

Coverage reports: coverage.json (coverage.py, 69 files) · coverage/clover.xml (clover, 13 files) — incremental-coverage-check v3.0.0

@velis74

velis74 commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Not needed: taskwire will track GET calls under their Idempotency-Key, so the busy indicator does not need the method.

@velis74 velis74 closed this Oct 27, 2026
@velis74
velis74 deleted the call-event-method branch October 27, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant