Repository navigation
Declare a middleware's OpenAPI parameters per operation (0.15.3) - #85
Merged
Merged
Conversation
✅ Incremental coverage — 100%
8 files not graded (1 ignored by pattern, 7 not source files)
Coverage reports: coverage.json (coverage.py, 69 files) · coverage/clover.xml (clover, 13 files) — incremental-coverage-check v3.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Middleware.openapi_parameters_for(viewset, action, configuration).route_viewsetcalls it for each operation it routes, with the middleware's@action_configurationvalue for that action (ByActionresolved); it returnsopenapi_parameters. A middleware that does not read its value on some operations (e.g. configuredFalse, or a viewset of its own package) overrides it and returns nothing for them. A function middleware'sopenapi_parametersattribute still applies to every operation.Needed by taskwire:
TaskwireMiddlewaredeclaresX-Taskwire-Token, but calls to taskwire's own viewset are never tracked, so the header does not belong on those operations. Without this, taskwire removes its middleware fromsettings.viewsets_command_middlewarewhile its viewset is routed (velis74/taskwire#33).Docs (command middleware guide,
route_viewsetreference) and CHANGELOG updated; version 0.15.3 for both packages.