Repository navigation
Conversation
eclipse-threadx#817 removed TXM_MODULE_USER_MODE and TXM_MODULE_MEMORY_PROTECTION from the supported options of the four Cortex-A35 and Cortex-A35 SMP module port headers without a test, so nothing kept either option from returning and a module from again loading as user-mode while running at the Module Manager's exception level. The new host test compiles the Module Manager's initialization and loaders against each of the four headers, at native 64-bit width because the ports are AArch64. Through the in-place and absolute loaders it expects user mode, alone or with memory protection, to be refused with TXM_MODULE_INVALID_PROPERTIES, and a privileged module, with or without shared external memory access, to load. Memory protection alone is refused on every port, so the test also checks the options the manager initializes from the port. The port's alignment macro makes the loaders report set-but-unused variables, which these targets silence. 4/4 pass on dev with zero warnings in the default, notify-disabled, both stack-checking and trace configurations; 17/17 Module Manager tests pass. With eclipse-threadx#817 reverted, 4/4 fail, 8 of 27 expectations each; re-adding the options to one header fails only its test. Both loaders take the supported-options check both ways. Assisted-by: Claude Code (Opus 5.5) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#817 removed TXM_MODULE_USER_MODE and TXM_MODULE_MEMORY_PROTECTION from the supported options of the four Cortex-A35 and Cortex-A35 SMP module port headers without a test, so nothing kept either option from returning and a module from again loading as user-mode while running at the Module Manager's exception level.
The new host test compiles the Module Manager's initialization and loaders against each of the four headers, at native 64-bit width because the ports are AArch64. Through the in-place and absolute loaders it expects user mode, alone or with memory protection, to be refused with TXM_MODULE_INVALID_PROPERTIES, and a privileged module, with or without shared external memory access, to load. Memory protection alone is refused on every port, so the test also checks the options the manager initializes from the port. The port's alignment macro makes the loaders report set-but-unused variables, which these targets silence.
4/4 pass on dev with zero warnings in the default, notify-disabled, both stack-checking and trace configurations; 17/17 Module Manager tests pass. With #817 reverted, 4/4 fail, 8 of 27 expectations each; re-adding the options to one header fails only its test. Both loaders take the supported-options check both ways.