Skip to content

INTER-2673: ci: stop passing unused npm token to release workflow - #219

Closed
JuroUhlar wants to merge 1 commit into
mainfrom
INTER-2673-drop-npm-token
Closed

JuroUhlar wants to merge 1 commit into
mainfrom
INTER-2673-drop-npm-token

Conversation

@JuroUhlar

@JuroUhlar JuroUhlar commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Context

INTER-2673

Why

The release workflow publishes with npm trusted publishing, so it no longer passes an npm token it does not use.

Things to note

  • release.yml already sets useTrustedPublishing: true and id-token: write. The Vue and Angular release workflows already pass only the two GitHub App keys.
  • In the shared workflow (dx-team-toolkit at v1), NPM_AUTH_TOKEN is declared required: false, so omitting it is valid.

Verification

Read release-sdk-changesets.yml at v1: the only use of the secret is NPM_TOKEN: ${{ inputs.useTrustedPublishing && '' || secrets.NPM_AUTH_TOKEN }}, and with the secret not passed that value is empty. Not verified: a real release run, which only happens on merge to main.

Change outline

One secret removed from the call to the shared release workflow.

     secrets:
       APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }}
       RUNNER_APP_PRIVATE_KEY: ${{ secrets.RUNNER_APP_PRIVATE_KEY }}
-      NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}

Publishing uses npm trusted publishing (OIDC), so NPM_AUTH_TOKEN is not needed.
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR doesn't contain any changesets. If there are user-facing changes, don't forget to run:

pnpm exec changeset

to create a changeset.

@github-actions

Copy link
Copy Markdown
Contributor

Wrong commit message format detected

We use Semantic Commit Messages in our project.

Warning
Probably you forgot to activate local git hooks.

Run the next command in the project root to activate local hooks:

sh ./install_hooks.sh

More info you can find in job logs

Commitlint Errors

Commit: 1cd02b2 `INTER-2673: ci: stop passing unused npm token to release workflow

Publishing uses npm trusted publishing (OIDC), so NPM_AUTH_TOKEN is not needed.`
Errors:

  • subject may not be empty
  • type may not be empty

@github-actions

Copy link
Copy Markdown
Contributor

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 96.79% 151/156
🟢 Branches 95.51% 85/89
🟢 Functions 97.78% 44/45
🟢 Lines 97.33% 146/150

Test suite run success

43 tests passing in 15 suites.

Report generated by 🧪jest coverage report action from 1cd02b2

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 96.79 95.5 97.77 97.33
🟢  src 100 100 100 100
🟢   detect-env.ts 100 100 100 100
🟢   env.types.ts 100 100 100 100
🟢   ...nt-context.ts 100 100 100 100
🟢   ssr.ts 100 100 100 100
🟢   ...sitor-data.ts 100 100 100 100
🟢  src/components 100 100 100 100
🟢   ...-provider.tsx 100 100 100 100
🟢   ...vironment.tsx 100 100 100 100
🟢  src/utils 88.09 87.5 92.3 90
🟢   ...is-defined.ts 100 100 100 100
🟢   ...-cache-key.ts 80.76 83.33 85.71 84 5,10,43,52
🟢   to-error.ts 100 100 100 100
🟢   ...mise-store.ts 100 100 100 100

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the change removing the unused npm token from the release workflow.

No open issues 🎉

What changed in this PR

Removes the unused npm token from the release workflow’s call to the shared workflow, aligning it with the existing npm trusted-publishing configuration.

Changes:

  • Stops forwarding NPM_AUTH_TOKEN while retaining both GitHub App private keys.
File Description
.github/​workflows/​release.yml Removes the unused npm secret from the shared release workflow call.

Review effort: Balanced

@JuroUhlar

Copy link
Copy Markdown
Contributor Author

Superseded by #220: the commit message needed to be a plain conventional commit (ci: ...) to pass the commit-message check, and fixing it here would need a force-push.

@JuroUhlar JuroUhlar closed this Nov 11, 2026
@JuroUhlar
JuroUhlar deleted the INTER-2673-drop-npm-token branch November 11, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants