Repository navigation
Conversation
Publishing uses npm trusted publishing (OIDC), so NPM_AUTH_TOKEN is not needed.
pnpm exec changesetto create a changeset. |
Wrong commit message format detectedWe use Semantic Commit Messages in our project.
Run the next command in the project root to activate local hooks: sh ./install_hooks.shMore info you can find in job logs Commitlint ErrorsCommit: 1cd02b2 `INTER-2673: ci: stop passing unused npm token to release workflow Publishing uses npm trusted publishing (OIDC), so NPM_AUTH_TOKEN is not needed.`
|
Coverage report
Test suite run success43 tests passing in 15 suites. Report generated by 🧪jest coverage report action from 1cd02b2 Show full coverage report
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change removing the unused npm token from the release workflow.
No open issues 🎉
What changed in this PR
Removes the unused npm token from the release workflow’s call to the shared workflow, aligning it with the existing npm trusted-publishing configuration.
Changes:
- Stops forwarding
NPM_AUTH_TOKENwhile retaining both GitHub App private keys.
| File | Description |
|---|---|
.github/workflows/release.yml |
Removes the unused npm secret from the shared release workflow call. |
Review effort: Balanced
|
Superseded by #220: the commit message needed to be a plain conventional commit ( |
Context
INTER-2673
Why
The release workflow publishes with npm trusted publishing, so it no longer passes an npm token it does not use.
Things to note
release.ymlalready setsuseTrustedPublishing: trueandid-token: write. The Vue and Angular release workflows already pass only the two GitHub App keys.dx-team-toolkitatv1),NPM_AUTH_TOKENis declaredrequired: false, so omitting it is valid.Verification
Read
release-sdk-changesets.ymlatv1: the only use of the secret isNPM_TOKEN: ${{ inputs.useTrustedPublishing && '' || secrets.NPM_AUTH_TOKEN }}, and with the secret not passed that value is empty. Not verified: a real release run, which only happens on merge tomain.Change outline
One secret removed from the call to the shared release workflow.
secrets: APP_PRIVATE_KEY: ${{ secrets.APP_PRIVATE_KEY }} RUNNER_APP_PRIVATE_KEY: ${{ secrets.RUNNER_APP_PRIVATE_KEY }} - NPM_AUTH_TOKEN: ${{ secrets.NPM_AUTH_TOKEN }}