Repository navigation
fix(runs): Remove containers left by a cancelled create - #256
Merged
Merged
Conversation
A run cancelled or timed out while its container was being created left that container behind until the agent restarted. Creation now finishes before the cancellation is applied, and anything it made is removed.
Code Review SummaryContainer creation is now wrapped so it finishes under a detached, one-minute-bounded context even when the caller's context ends, then fails with the caller's context error and destroys whatever the daemon created. A pre-flight context check avoids contacting the daemon at all when the caller is already done. Firecracker's root-image preparation uses the same wrapper, so its container is cleaned up too. Tests exercise cancellation reaching the daemon across both runtimes. 🚀 Key Improvements
📉 Regressions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A run cancelled or timed out while its container was being created left that container behind until the agent restarted. Creation now finishes before the cancellation applies, and anything it made is removed.