Repository navigation
Add a scaleDown option to doc.image() - #1839
Merged
Merged
Conversation
Member
|
Please research the API of other libraries to accomplish this situation |
kroplabeskidu
force-pushed
the
image-fit-no-upscale
branch
from
November 1, 2026 14:25
9a5ea76 to
3bb2d52
Compare
Contributor
Author
|
Compared with similar APIs:
Most of these treat it as a fit mode rather than a flag. PDFKit already has If you prefer a flag on |
# Conflicts: # CHANGELOG.md
kroplabeskidu
force-pushed
the
image-fit-no-upscale
branch
from
November 1, 2026 15:41
3bb2d52 to
214d08f
Compare
Member
|
Much better |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature. Fixes #1347
With
fit, an image smaller than the rectangle gets enlarged and can look pixelated.doc.image(path, { scaleDown: [w, h] })works likefit, but keeps such an image at its own size. Images larger than the rectangle are still scaled down, andalign/valignstill position the image inside the rectangle.Checklist: