Repository navigation
Restore the remembered fill color in restore() - #1852
Open
kroplabeskidu wants to merge 1 commit into
Open
kroplabeskidu wants to merge 1 commit into
kroplabeskidu wants to merge 1 commit into
Conversation
# Conflicts: # CHANGELOG.md
kroplabeskidu
force-pushed
the
restore-fill-color
branch
from
November 1, 2026 15:42
ea4a7db to
21cd4cf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix. Fixes #1199
The text wrapper sets
_fillColoragain on each new page, butrestore()left that value alone. So afterdoc.save().rect(...).fill('#f00').restore(), text started in black and turned red from the second page on.save()andrestore()now keep_fillColortoo, so new pages get the same color as the graphics state.This changes what a page break does after
restore(), but only towards what the first page already shows.Checklist: