Repository navigation
feat(traces): Send one transaction per workflow run with job and step spans - #125
Draft
sentry-junior[bot] wants to merge 1 commit into
Draft
sentry-junior[bot] wants to merge 1 commit into
sentry-junior[bot] wants to merge 1 commit into
Conversation
… spans Co-Authored-By: Armen Zambrano Gasparnian <44410+armenzg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A smaller take on #73. Like #73, it sends one transaction per workflow run, with a span for each job and a child span for each step, so a run shows up as one trace and not as a flat list of job transactions.
#73 builds the trace from
workflow_jobwebhooks. It buffers jobs in memory and uses timers to guess when a run has finished, which breaks on Cloud Run when there are several instances or an instance restarts. This PR waits for theworkflow_runcompletedwebhook and makes one call to list the run's jobs. The app already handles that webhook for commit traces. Nothing is kept in memory and nothing has to be guessed.Rollout follows the review on #73:
WORKFLOW_TRACES_ORGS=getsentryturns it on for the Sentry org only while we check it.Known limits:
via @armenzg.
--
View Session [Sentry]