Repository navigation
Warn about direct CHANGELOG.md changes in PR checks - #4294
Open
mario-campos wants to merge 2 commits into
Open
mario-campos wants to merge 2 commits into
mario-campos wants to merge 2 commits into
Conversation
Split workflow activation from #4217 while keeping the comment action loaded from trusted main. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The workspace-only install omits required root dependencies, leaving warning and resolution comment scripts at risk of module-loading failures in CI.
1 open issue
What changed in this PR
Activates warnings for direct CHANGELOG.md edits in repository PR checks, using the comment action supplied by prerequisite #4217. Production CodeQL workflows are unaffected.
Changes:
- Detects changelog modifications and exposes the result as a job output.
- Extends the commenting job with trusted
maincheckout and Node/dependency setup. - Adds sticky warning and update-only resolution comments, excluding release, backport, mergeback, and bundle-update branches.
| File | Description |
|---|---|
.github/workflows/pr-checks.yml |
Wires changelog detection and warning/resolution comments into PR checks while preserving repo-size commenting. |
Review effort: Balanced (auto)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR adds a PR check for non-release/mergeback/update-bundle PRs. The check posts a sticky PR comment if
CHANGELOG.mdhas been modified in the PR, warning the author to instead direct their change to a change-note.This PR is split-off from #4217, which retains the prerequisite
post-commentAction.Note
CI is EXPECTED TO FAIL until #4217 is merged. The write-permission job intentionally checks out trusted
main, not the PR head, and the prerequisite./.github/actions/post-commentaction is not on main yet.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types: None of the production workflow types; only this repository's PR checks.
Products: No production analysis behavior changes.
Environments:
How did/will you validate this change?
If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
Are there any special considerations for merging or releasing this change?
main, Add CHANGELOG.md modification check and warning comment #4217 must merge first. CI is expected to fail until then. After Add CHANGELOG.md modification check and warning comment #4217 is merged, then this PR will be rebased.Merge / deployment checklist