Repository navigation
no network - #2338
Merged
Merged
no network#2338
Conversation
<!-- aent --> SUSE and openSUSE package builders disable network access for reproducible builds. Allow them to exclude network-using tests with `pytest -m 'not net'` while retaining local filesystem tests. Register `net` in `pyproject.toml` and document in `CONTRIBUTING.md` that it includes loopback sockets and fixture-triggered package downloads, not just internet access. Mark the daemon-based repository tests, stalled remote timeout cases, daemon restart test, installation test, and the already-skipped external clone test. Mark only the daemon-launching cleanup parameter so the other cleanup cases remain selected. Existing skips and test bodies remain unchanged. Normalize TOML formatting and imports in the touched files. Assisted-by: GPT 6.0 Astra Co-authored-by: GPT 6.0 Astra <codex@openai.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the network-test marking and offline test-selection changes.
No open issues 🎉
What changed in this PR
This PR supports running GitPython’s tests on network-restricted builders, continuing the work in #2337 by identifying tests that require internet access or local sockets.
Changes:
- Registers
pytest.mark.netand documents exclusion withpytest -m 'not net'. - Marks network-dependent tests, including only the relevant parameterized cleanup case.
- Tidies imports and TOML formatting.
| File | Description |
|---|---|
test/test_remote.py |
Marks remote-operation and timeout tests that use network sockets. |
test/test_installation.py |
Marks the installation test that downloads dependencies. |
test/test_clone.py |
Marks an already-skipped network clone test. |
test/test_cleanup.py |
Marks daemon cleanup tests and the network-dependent decorator parameter. |
test/test_base.py |
Marks the remote-repository fixture test. |
pyproject.toml |
Registers the net marker and normalizes formatting. |
CONTRIBUTING.md |
Documents marker usage, loopback coverage, and offline test selection. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #2337