Repository navigation
fix(tracing): do not derive trace level from W3C sampled flag - #542
Merged
Merged
Conversation
Stop setting context[:level] based on the W3C traceparent sampled bit when X-Instana-L is absent, ensuring trace suppression and level handling are driven exclusively by Instana headers. Signed-off-by: Arjun Rajappa <arjun.rajappa@ibm.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Foreign W3C
traceparentsampled flags were previously being used to infer Instana tracelevel(and trace suppression) whenX-Instana-Lwas absent. Instana trace level and suppression decisions should be governed strictly by Instana headers rather than foreign W3C trace flags.What
Instana::InstrumentedRequestthat setcontext[:level]based oncontext[:external_trace_flags].RackInstrumentedRequestTestto assert thatcontext[:level]remainsnilwhen only W3C headers are present.