Repository navigation
tst_ToJson: handle musl's truncated formatting of 2^64 - #353
Open
Anmol-In-Verse wants to merge 1 commit into
Open
Anmol-In-Verse wants to merge 1 commit into
Anmol-In-Verse wants to merge 1 commit into
Conversation
The tst_ToJson tests expect 2^64 to format as 1.8446744073709552e+19 (correctly rounded to 17 significant digits, as done by glibc, MSVC's UCRT, Apple's and BSD's libcs). musl's printf() instead truncates the decimal representation and produces 1.8446744073709551e+19, which makes tst_ToJson fail on Alpine Linux and other musl-based distributions. musl deliberately defines no identification macro, so detect it by exclusion: Linux with neither glibc, uClibc nor Bionic. On such systems the four affected test rows now expect musl's truncated output instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tst_ToJson tests expect 2^64 to format as 1.8446744073709552e+19
(correctly rounded to 17 significant digits, as done by glibc, MSVC's
UCRT, Apple's and BSD's libcs). musl's printf() instead truncates the
decimal representation and produces 1.8446744073709551e+19, which makes
tst_ToJson fail on Alpine Linux and other musl-based distributions.
musl deliberately defines no identification macro, so detect it by
exclusion: Linux with neither glibc, uClibc nor Bionic. On such systems
the four affected test rows now expect musl's truncated output instead.
Fixes #352