Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A
BaseExceptionGroupcontainingKeyboardInterruptcan be pickled by the standard library, but fails to unpickle aftertblib.pickling_support.install()withTypeError: BaseExceptionGroup.__new__() takes exactly 2 arguments (0 given). Apply the existing exception-group constructor handling to the base class too.The regression test covers global, instance and class registration, protocols 0 and the highest supported protocol, a nested
ExceptionGroup, notes and tracebacks. Includes the changelog and AUTHORS entries requested by the contribution guidelines.Evidence
TypeErroron Python 3.14.After: the complete tests and README examples pass: Python 3.14 70 passed; Python 3.11 70 passed; Python 3.9 62 passed, 8 skipped (exception groups require Python 3.11).
PYTHONNODEBUGRANGES=1 python -m pytest --benchmark-disable -q tests README.rst;tox -e py311,py39 -- pytest --benchmark-disable -q tests README.rst.tox -e docs: HTML builds with the existing missingautoapi/indexwarning; linkcheck fails because the unchanged Coveralls badge URL returns HTTP 403. The full tox matrix is not claimed to pass.Prepared with AI assistance and independently reviewed by another agent; no maintainer review is implied.
Merge Danger
Door: two-way. The change is a narrow, reversible correction to the existing reducer.
Blast Radius: serialization. It adds the existing group-argument handling to genuine
BaseExceptionGroupinstances while retainingExceptionGroupbehavior and the pre-3.11 guard.