Repository navigation
feat(chart): add extraVolumes and extraVolumeMounts - #131
Merged
Merged
Conversation
Allow mounting extra volumes into the manager pod, e.g. to extend the trusted CAs via SSL_CERT_DIR when running behind a TLS-inspecting firewall. Document the setup in the README and bump the chart to 0.5.0. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Show optional: true on the CA ConfigMap volume so a missing ConfigMap leaves only the system CAs, and list Go's default CA directories in SSL_CERT_DIR so system trust stays intact regardless of the image's truststore layout. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
setup-helm silently fell back to v3.18.4 when the latest-release lookup failed, but the e2e suite needs Helm v4 (--wait=watcher). Request the latest release and disable the fallback so a failed lookup fails the job visibly. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
varun-saraogi
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manager.extraVolumesandmanager.extraVolumeMountsto the Helm chart (default[], so rendered output is unchanged by default).optional: true, so a missing ConfigMap leaves only the system CAs) and extendSSL_CERT_DIR, listing Go's default CA directories explicitly so system trust stays intact.Test plan
helm lint deploy/charts/github-token-managerhelm templatewith the example values renders the env var, volume and mounthelm templatewith default values renders no extra volumes🤖 Generated with Claude Code