Skip to content

feat(chart): add extraVolumes and extraVolumeMounts - #131

Merged
isometry merged 3 commits into
mainfrom
feat/chart-extra-volumes
Nov 5, 2026
Merged

isometry merged 3 commits into
mainfrom
feat/chart-extra-volumes

Conversation

@isometry

@isometry isometry commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Add manager.extraVolumes and manager.extraVolumeMounts to the Helm chart (default [], so rendered output is unchanged by default).
  • Document how to trust additional CAs behind a TLS-inspecting firewall: mount a ConfigMap of PEM CAs (optional: true, so a missing ConfigMap leaves only the system CAs) and extend SSL_CERT_DIR, listing Go's default CA directories explicitly so system trust stays intact.
  • Bump chart version to 0.5.0.
manager:
  env:
    - name: SSL_CERT_DIR
      value: /etc/ssl/certs:/etc/pki/tls/certs:/etc/ssl/extra-ca
  extraVolumes:
    - name: extra-ca
      configMap:
        name: corp-ca
        optional: true
  extraVolumeMounts:
    - name: extra-ca
      mountPath: /etc/ssl/extra-ca
      readOnly: true

Test plan

  • helm lint deploy/charts/github-token-manager
  • helm template with the example values renders the env var, volume and mount
  • helm template with default values renders no extra volumes
  • End-to-end against a real TLS-inspecting proxy (e.g. mitmproxy in Kind) — not done

🤖 Generated with Claude Code

isometry and others added 3 commits November 5, 2026 12:10
Allow mounting extra volumes into the manager pod, e.g. to extend the
trusted CAs via SSL_CERT_DIR when running behind a TLS-inspecting
firewall. Document the setup in the README and bump the chart to 0.5.0.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Show optional: true on the CA ConfigMap volume so a missing ConfigMap
leaves only the system CAs, and list Go's default CA directories in
SSL_CERT_DIR so system trust stays intact regardless of the image's
truststore layout.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
setup-helm silently fell back to v3.18.4 when the latest-release lookup
failed, but the e2e suite needs Helm v4 (--wait=watcher). Request the
latest release and disable the fallback so a failed lookup fails the
job visibly.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@isometry
isometry merged commit 2c3cef6 into main Nov 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants