Repository navigation
Let a checkout opt out of the fo build check - #90
Merged
Merged
Conversation
A Fortran subproject that configures only inside its superbuild (SIESTA in Stellarator-Tools) cannot pass a standalone build; hooks.foCheck=false skips fo for that checkout, like hooks.repoPreCommit for repository configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hook runs
fo hook pre-commiton every checkout with Fortran sources and a top-levelCMakeLists.txt. SIESTA's repository is such a checkout but configures only inside the Stellarator-Tools superbuild (itsCMakeLists.txtdepends on the superbuild targetpull_siesta), so every commit there fails:scripts/setup/pre-commit now skips the fo check when the checkout sets
git config hooks.foCheck false, ashooks.repoPreCommit=falsealready does for repository pre-commit configurations; the hygiene and secret checks still run.git-hooks.shgets the newhook_sha256.The global hook test in the prompts repository gains a case: a Fortran CMake project that cannot configure blocks a commit, and commits after the opt-out. It fails with the previous hook and passes with this one.
Chris&AI