Repository navigation
Validate animation blend weight range (#2025) - #3082
adrian-andrzjewski wants to merge 1 commit into
Conversation
jaime-jmebot
left a comment
There was a problem hiding this comment.
Thanks for tackling this validation gap. The change keeps the existing setter behavior for valid values while making the allowed range explicit for both blend weight and maximum transition weight.
I reviewed the range checks and the regression tests. The negated inclusive comparisons correctly reject NaN as well as values below zero, above one, and either infinity; because both setters validate before assigning, rejected inputs leave the prior value untouched. The tests cover both endpoints and representative invalid inputs for each setter, including that unchanged-value behavior.
Looks good to me—thanks for including focused coverage for the edge cases.
|
@riccardobl @yaRnMcDonuts Could one of you review this change for #2025? It validates BlendableAction weight bounds and adds regression coverage; :jme3-core:check passes. |
Summary
[0, 1]range inBlendableAction.setWeight.setMaxTransitionWeight.Closes #2025
Validation
:jme3-core:test --tests com.jme3.anim.tween.action.BlendableActionWeightTest --no-daemon:jme3-core:test --no-daemon:jme3-core:check --no-daemon(passed; reports existing Checkstyle warnings in unrelated files)git diff --check