Repository navigation
Apply static glTF morph weights (#2110) - #3084
adrian-andrzjewski wants to merge 1 commit into
Conversation
jaime-jmebot
left a comment
There was a problem hiding this comment.
Hi, thanks for taking this on — this closes an important gap in the glTF morph path by applying static node/mesh weights to every primitive and ensuring morph-capable geometry has a control even when there are no animation tracks.
I reviewed the loader changes alongside the existing MorphControl behavior. Applying weights after each primitive is created gives each geometry its own state, while the node-over-mesh fallback follows the glTF precedence. The control setup also accounts for the completed scene graph, which is important for controls created earlier during animation or skin processing. The new fixture and assertions cover node overrides, mesh defaults across multiple primitives, implicit zero weights, and the no-animation case, so they provide useful regression coverage for the intended behavior.
I didn’t find anything requiring changes. The PR reports the plugin checks passing, and I see no outstanding CI checks attached here. Looks good to me—thanks for the focused fix!
Summary
Validation
Closes #2110