Repository navigation
fix: retire EOL Node 20 so CI is green again; add Node 26 - #85
Merged
Merged
Conversation
npm@latest (12.x) requires node ^22.22.2 || ^24.15.0 || >=26, so the `npm i -g npm@latest` step fails on node:20-alpine and fail-fast cancels every other job. Node 20 reached EOL on 2026-04-30 and its upstream image is frozen; the published kooldev/node:20 tag stays on Docker Hub as legacy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
The scoped retirement is consistent across generation, local builds, CI, and documentation, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Retires the EOL Node 20 image from generation and build pipelines to resolve the scheduled CI failure, while documenting that its published Docker Hub tag remains available.
Changes:
- Removes Node 20 from template generation, local builds, and both CI matrices.
- Deletes the Node 20 Dockerfile and supporting files.
- Moves Node 20 to the README’s legacy tags with a historical Dockerfile link.
| File | Description |
|---|---|
| README.md | Lists Node 20 as legacy and links its historical Dockerfile. |
| kool.yml | Removes the local Node 20 build command. |
| fwd-template.json | Removes Node 20 template generation. |
| 20/root-npmrc | Deletes retired root package-manager settings. |
| 20/kool-npmrc | Deletes retired user package-manager settings. |
| 20/entrypoint | Deletes the retired image’s entrypoint. |
| 20/Dockerfile | Deletes the Node 20 image definition. |
| .github/workflows/ci-cd.yml | Removes Node 20 from build and publishing matrices. |
Review effort: Balanced
Rendered from the template like the other versions. node:26-alpine no longer ships yarn, so the template installs it only when missing; 22 and 24 keep the yarn from their base images. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits: retire EOL Node 20 (the CI fix), then add Node 26.
Why
Scheduled CI has failed every week since 2026-07-12. The failure starts at
RUN npm i --location=global npm@lateston the 20 image:Because of
fail-fast, that one failure cancels every other job. So no images (22, 24, 24-nginx) have been pushed since 2026-07-05. GitHub then turned the workflow off for inactivity. I've turned it back on.Change
Drop the
20build: the directory,fwd-template.json,kool.yml, and both CI matrices. Node 20 reached EOL on 2026-04-30 (last release 20.20.2), and the upstreamnode:20-alpineimage no longer changes.README: move
20into Legacy tags, linking to the last commit that has its Dockerfile. The publishedkooldev/node:20tag stays on Docker Hub. This follows how 16, 18 and 21 were retired.Add Node 26 (becomes LTS on 2026-10-28).
26/is generated from the template throughfwd-template.json+kool run template, and is wired intokool.yml, both CI matrices and the README.Template:
node:26-alpineno longer ships yarn, so the template now runscommand -v yarn || npm install -g yarn. For 22 and 24 nothing changes: yarn is still the base image's/opt/yarn-v1.22.22. On 26 it's installed with npm, also 1.22.22.Verified locally (arm64)
The CI smoke tests (
node/npm/yarn -v, with and withoutASUSER=1000) pass for all three. 24-nginx also builds.Decisions / deviations
npm@11for 20 only) would keep rebuilding a Node line that gets no more fixes. Retiring it matches what was done for earlier EOL tags.yarn -vcheck for 26. kool presets expect yarn, so all tags keep the same tools.24-nginxbuildsFROM kooldev/node:24from Docker Hub while 24 builds in parallel, so it is always one cycle behind. After this merges, run the workflow a second time so 24-nginx picks up 24.22.1.🤖 Generated with Claude Code