Repository navigation
test: Add Redis, DynamoDB, and Consul stores to the contract test service - #266
Merged
Merged
Conversation
added 3 commits
November 17, 2026 14:19
…vice The test service now reads the persistent store configuration from the top-level SDK configuration and from the data system configuration, and declares the three persistent store capabilities. CI starts the stores and runs the persistence tests. The test service moves to port 9000, because the harness expects DynamoDB on 8000. Generated-by: termag
… updates only without a data source The Makefile passes TEST_SERVICE_PORT as PORT, but the service always listened on 8000. A v2 configuration with a persistent store and no data source now uses external updates only, so that the SDK reads only from the store. Generated-by: termag
With no data source, the SDK does not evaluate flags until the store has the init marker. The DynamoDB store writes a deleted item as the string null, which the harness does not accept as a tombstone. Generated-by: termag
There was a problem hiding this comment.
Risk: medium.
Automated risk review (dry run): Medium
This PR would not be automatically approved. Human approval required.
Why: CI workflow definitions in .github/workflows/java-server-sdk.yml and nightly-contract-tests.yml are never Low, and this also wires Redis/DynamoDB/Consul into the contract-test service while suppressing persistence tests that still fail. Human review is needed and no reviewers were assigned.
If you disagree with this review, share this PR in #feedback-agent-approvals or submit a changes-requested review explaining why.
Sent by Cursor Approval Agent: Dry-Run PR Approver
kinyoklion
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
The contract test service now configures a persistent data store when the harness asks for one, and declares the
persistent-data-store-redis,persistent-data-store-dynamodb, andpersistent-data-store-consulcapabilities. It reads the store from the top-levelpersistentDataStoreconfiguration (v2 harness) and fromdataSystem.store.persistentDataStorewith its store mode (v3 harness). This replaces the commented-out placeholder inSdkClientEntity.launchdarkly-java-server-sdk-redis-store3.2.0,launchdarkly-java-server-sdk-dynamodb-store5.0.1, andlaunchdarkly-java-server-sdk-consul-store5.0.0. Each excludes its transitivelaunchdarkly-java-server-sdk, so the tests run against the SDK in this repository.sdk-contract-teststable, regionus-east-1, and dummy credentials. The Consul DSN is a barehost:port.noCaching,cacheSeconds, andcacheForever.Components.externalUpdatesOnly(), as the Go test service does.PORT, which the Makefile sets fromTEST_SERVICE_PORT. It still defaults to 8000.CI starts Redis, DynamoDB, and Consul at the start of the contract test job, and the v2 and v3 runs enable the persistence tests, in both the PR workflow and the nightly workflow. The test service moves to port 9000, because the harness expects DynamoDB on port 8000.
The suppressions cover persistence tests that fail because of SDK behavior, not the test service:
CLIENT_NOT_READYuntil the store has the$initedmarker. The harness expects the SDK to read whatever the store holds. This fails the no-data-source tests on all three stores: the prefix tests, the v2 daemon mode group, and the v3 no-data-source, collection cardinality, and tombstone groups.null, which the harness does not accept as a tombstone. This fails the DynamoDBdata source deletions respect versioningtest.With the suppressions, the v2 suite passes locally with 6,324 tests run and the v3 suite with 6,395 tests run.
Opened from termag
Note
Overview
Enables persistent data store coverage in the Java server SDK contract test service and CI. The test service now advertises Redis, DynamoDB, and Consul persistence capabilities, builds store integrations from harness config (v2 top-level
persistentDataStoreand v3dataSystem.store), supports cache modes, and can bind to a configurable port viaPORT/TEST_SERVICE_PORT.CI and local docs start Redis, DynamoDB Local, and Consul before contract runs, turn on harness persistence tests, and move the test service to port 9000 so DynamoDB can stay on 8000. Gradle pulls in the published store modules while excluding their bundled SDK so tests exercise the in-repo SDK.
Suppressions skip persistence scenarios that fail due to known SDK vs harness mismatches (e.g. no-data-source/
$initedbehavior and DynamoDB tombstone handling).Reviewed by Cursor Bugbot for commit aa58267. Bugbot is set up for automated code reviews on this repo. Configure here.