Repository navigation
Conversation
…ls (AIC-3646) An interactive attach asked for the project and the variation, and only then searched LaunchDarkly for tools or skills. When the project had none, the user learned that at the last step. The attach now reads one page of the catalog right after the project step. When the project has no tool or skill of the kind, it stops with an error that names the project, before the variation prompt. An attach with a named key skips the check, because the read of that key gives its own error. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
ctawiah
marked this pull request as ready for review
November 18, 2026 20:43
ctawiah
requested review from
nkester-ld and
tiffanylphan
and removed request for
a team
November 18, 2026 20:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human
ldcli sync prompts attach toolandattach skillnow stop right after the project step when the project has no tool or skill to attach. Before, the command asked for the project and the variation, and the user found the empty list only at the last step.Why
Nate reported this in the October blitz (AIC-3646). The catalog search was the last step of the flow, so an empty project cost the user two answers before the command could say that there was nothing to attach.
What changes
attachToVariationininternal/sync/prompt/attach.goreads one page of the catalog afterselectAttachmentProjectand beforeselectManagedVariation. When the page is empty, it returns:Testing
go test ./...passes, andgolangci-lint run ./internal/sync/...reports 0 issues.TestPromptAttachToolStopsWhenTheProjectHasNoToolsandTestPromptAttachSkillStopsWhenTheProjectHasNoSkillsfail onmainand pass here. They assert the error text, one read of the catalog, and that nothing was attached.Requirements
Related issues
🤖 Generated with Claude Code
Note
Overview
Interactive
attach tool/attach skillflows now fail right after project selection when the LaunchDarkly project has no tools or skills of that kind, instead of prompting for a variation first and only showing an empty catalog at the end.After
selectAttachmentProject,attachToVariationcalls newrequireAttachments, which fetches one catalog page viaSearchAttachmentsand returns an error such asproject "production" has no tools to attach. Create one in LaunchDarkly first.Attaches that specify a named key skip this check (missing keys still fail on the single-resource read).Tests add GET list handling on the acceptance
directAPIfake plus cases that assert the early error, a single catalog read, and that nothing is attached.Reviewed by Cursor Bugbot for commit fcbeed1. Bugbot is set up for automated code reviews on this repo. Configure here.
Related Jira issue: AIC-3646: [blitz] Show an empty tool or skill list before the last attach step