Skip to content

chore: delete dead components, batch 1 (CM-1634) - #5311

Merged
gaspergrom merged 2 commits into
mainfrom
chore/issue-334-delete-dead-components-batch-1
Nov 14, 2026
Merged

gaspergrom merged 2 commits into
mainfrom
chore/issue-334-delete-dead-components-batch-1

Conversation

@gaspergrom

Copy link
Copy Markdown
Contributor

Deletes seven components nothing renders: both github-details-modal.vue files (GitHub and GitHub Nango), activity-icon.vue, lf-sub-projects-list-modal.vue, project-groups-list.page.vue, contributor-details-projects-sorting.vue and lf-project-filter-button.vue.

  • Also removes what they orphaned: the commented-out /project-groups route, the searchProjectGroup store action, PageEventKey.PROJECT_GROUPS, two unused images (conf.jpg, integrations/custom/lfx.png) and their legacy-files.json entries. The built CSS loses a few unused Tailwind rules.
  • Several of these files were edited by the defineOptions codemods after this branch was cut; the rebase keeps the deletes. Nothing on current main imports them or uses their tags or component names.
  • The /project-groups redirects stay for lfx-cdp-insights-ops#455.
  • Lint, cycle check, vue-tsc (0 errors), the production build and the Storybook build pass on this branch rebased on current main. A smoke run with a mocked API matched main.

Closes linuxfoundation/lfx-cdp-insights-ops#334

Removes the commented-out project groups route as well.
The live /project-groups redirects stay for CM-1757.

Refs linuxfoundation/lfx-cdp-insights-ops#334

Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 13:16
@cursor

cursor Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Deletes unreferenced UI and store/monitoring symbols only; no auth, data, or integration runtime changes.

Overview
This PR removes seven unused Vue components (GitHub details modals for both integration configs, activity icons, sub-project list modal, standalone project groups list page, contributor project sorting UI, and the legacy project filter button) plus related dead wiring.

Orphaned pieces are cleaned up: entries drop out of legacy-files.json, the commented /project-groups route block is removed from admin.routes.ts, searchProjectGroup is removed from the LF segments store, and PageEventKey.PROJECT_GROUPS is dropped from monitoring types. Integration and admin flows that still use project groups elsewhere are unchanged aside from no longer depending on these files.

Reviewed by Cursor Bugbot for commit 55e2ecc. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the unused-component and dead-code cleanup.

No open issues 🎉

What changed in this PR

Removes unused Vue components and related dead code from the CDP frontend, reducing maintenance overhead without intending to change active UI behavior.

Changes:

  • Deletes seven unused components across integrations, activities, project administration, and contributor details.
  • Removes the orphaned searchProjectGroup action and PROJECT_GROUPS page-event key.
  • Deletes commented-out project-group routing code and obsolete ESLint exemptions; existing redirects remain unchanged.
File Description
frontend/​src/​shared/​modules/​monitoring/​types/​event.ts Removes the unused project-groups page-event key.
frontend/​src/​modules/​lf/​segments/​store/​segments.store.ts Removes the unused project-group search action and export.
frontend/​src/​modules/​lf/​segments/​components/​filter/​lf-project-filter-button.vue Deletes the unused project-filter button.
frontend/​src/​modules/​contributor/​components/​details/​overview/​project/​contributor-details-projects-sorting.vue Deletes the unused contributor-project sorting control.
frontend/​src/​modules/​admin/​modules/​projects/​pages/​project-groups-list.page.vue Deletes the unused project-groups page.
frontend/​src/​modules/​admin/​modules/​projects/​components/​lf-sub-projects-list-modal.vue Deletes the unused sub-project selection modal.
frontend/​src/​modules/​admin/​admin.routes.ts Removes only commented-out route and import code.
frontend/​src/​modules/​activity/​components/​activity-icon.vue Deletes the unused activity-icon component.
frontend/​src/​config/​integrations/​github/​components/​github-details-modal.vue Deletes the unused GitHub details modal.
frontend/​src/​config/​integrations/​github-nango/​components/​github-details-modal.vue Deletes the unused GitHub Nango details modal.
frontend/​.eslint/​legacy-files.json Removes exemptions for deleted components.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for this cleanup of unused frontend components and supporting code.

No open issues 🎉

Review effort: Balanced

@gaspergrom
gaspergrom merged commit 92ffed1 into main Nov 14, 2026
14 checks passed
@gaspergrom
gaspergrom deleted the chore/issue-334-delete-dead-components-batch-1 branch November 14, 2026 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants