Repository navigation
chore: delete dead components, batch 1 (CM-1634) - #5311
Conversation
Removes the commented-out project groups route as well. The live /project-groups redirects stay for CM-1757. Refs linuxfoundation/lfx-cdp-insights-ops#334 Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
PR SummaryLow Risk Overview Orphaned pieces are cleaned up: entries drop out of Reviewed by Cursor Bugbot for commit 55e2ecc. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the unused-component and dead-code cleanup.
No open issues 🎉
What changed in this PR
Removes unused Vue components and related dead code from the CDP frontend, reducing maintenance overhead without intending to change active UI behavior.
Changes:
- Deletes seven unused components across integrations, activities, project administration, and contributor details.
- Removes the orphaned
searchProjectGroupaction andPROJECT_GROUPSpage-event key. - Deletes commented-out project-group routing code and obsolete ESLint exemptions; existing redirects remain unchanged.
| File | Description |
|---|---|
frontend/src/shared/modules/monitoring/types/event.ts |
Removes the unused project-groups page-event key. |
frontend/src/modules/lf/segments/store/segments.store.ts |
Removes the unused project-group search action and export. |
frontend/src/modules/lf/segments/components/filter/lf-project-filter-button.vue |
Deletes the unused project-filter button. |
frontend/src/modules/contributor/components/details/overview/project/contributor-details-projects-sorting.vue |
Deletes the unused contributor-project sorting control. |
frontend/src/modules/admin/modules/projects/pages/project-groups-list.page.vue |
Deletes the unused project-groups page. |
frontend/src/modules/admin/modules/projects/components/lf-sub-projects-list-modal.vue |
Deletes the unused sub-project selection modal. |
frontend/src/modules/admin/admin.routes.ts |
Removes only commented-out route and import code. |
frontend/src/modules/activity/components/activity-icon.vue |
Deletes the unused activity-icon component. |
frontend/src/config/integrations/github/components/github-details-modal.vue |
Deletes the unused GitHub details modal. |
frontend/src/config/integrations/github-nango/components/github-details-modal.vue |
Deletes the unused GitHub Nango details modal. |
frontend/.eslint/legacy-files.json |
Removes exemptions for deleted components. |
Review effort: Balanced
Deletes seven components nothing renders: both
github-details-modal.vuefiles (GitHub and GitHub Nango),activity-icon.vue,lf-sub-projects-list-modal.vue,project-groups-list.page.vue,contributor-details-projects-sorting.vueandlf-project-filter-button.vue./project-groupsroute, thesearchProjectGroupstore action,PageEventKey.PROJECT_GROUPS, two unused images (conf.jpg,integrations/custom/lfx.png) and theirlegacy-files.jsonentries. The built CSS loses a few unused Tailwind rules./project-groupsredirects stay for lfx-cdp-insights-ops#455.Closes linuxfoundation/lfx-cdp-insights-ops#334