Skip to content

chore: delete dead components, batch 2 (CM-1635) - #5312

Merged
gaspergrom merged 2 commits into
mainfrom
chore/issue-335-delete-dead-components-batch-2
Nov 14, 2026
Merged

gaspergrom merged 2 commits into
mainfrom
chore/issue-335-delete-dead-components-batch-2

Conversation

@gaspergrom

Copy link
Copy Markdown
Contributor

Deletes nine components nothing renders: member-last-activity.vue, member-reach.vue, OrganizationTeamOrganizationSetting.vue, shared/loading/page-loader.vue, shared/modules/entities/Entities.vue, shared/tag/tag-list.vue, the ui-kit InputPassword (with its story), lfx/dropdown/dropdown-group-title.vue and ScrollControll.vue.

  • Also removes the now-unused group-title styles from dropdown.scss and the deleted files' legacy-files.json entries.
  • The team-organization saved-view setting never rendered on main, so removing it changes nothing on screen.
  • Some of these files were edited by the defineOptions codemods after this branch was cut; the rebase keeps the deletes. Nothing on current main imports them or uses their tags or component names.
  • Lint, cycle check, vue-tsc (0 errors), the production build and the Storybook build pass on this branch rebased on current main. A smoke run with a mocked API matched main.

Closes linuxfoundation/lfx-cdp-insights-ops#335

Refs linuxfoundation/lfx-cdp-insights-ops#335

Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 13:16
@cursor

cursor Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

PR Summary

Low Risk
Deletion-only cleanup of unreferenced components with no runtime wiring; intended behavior unchanged.

Overview
Removes nine unused Vue components and related assets that nothing imports or renders: member member-last-activity / member-reach, organization saved-view OrganizationTeamOrganizationSetting, shared page-loader, Entities, and tag-list, ui-kit InputPassword (plus its Storybook story), lfx/dropdown/dropdown-group-title, and ScrollControll.

ESLint legacy allowlists in legacy-files.json are trimmed so deleted files are no longer exempted from vue/component-api-style, vue/block-lang, or vue/prefer-define-options.

Dropdown styling drops the unused &__group-title block and tightens minor SCSS formatting on danger-state selectors in dropdown.scss.

Reviewed by Cursor Bugbot for commit 2213b52. Bugbot is set up for automated code reviews on this repo. Configure here.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the unused-component cleanup.

No open issues 🎉

What changed in this PR

Removes nine unused Vue components from the CDP frontend, reducing legacy code without intended changes to the rendered UI.

Changes:

  • Deletes unused member, organization-setting, shared, and UI-kit components.
  • Removes the deleted password input’s Storybook stories and dropdown group-title styles.
  • Cleans up ESLint legacy exemptions for deleted files.
File Description
frontend/​src/​ui-kit/​scrollcontroll/​ScrollControll.vue Deletes unused scroll-event wrapper.
frontend/​src/​ui-kit/​lfx/​dropdown/​dropdown.scss Removes group-title styles and adjusts formatting.
frontend/​src/​ui-kit/​lfx/​dropdown/​dropdown-group-title.vue Deletes unused dropdown group title.
frontend/​src/​ui-kit/​input-password/​InputPassword.vue Deletes unused password input.
frontend/​src/​ui-kit/​input-password/​InputPassword.stories.ts Removes stories for the deleted input.
frontend/​src/​shared/​tag/​tag-list.vue Deletes unused expandable tag list.
frontend/​src/​shared/​modules/​entities/​Entities.vue Deletes unused expandable entity wrapper.
frontend/​src/​shared/​loading/​page-loader.vue Deletes unused loading indicator.
frontend/​src/​modules/​organization/​config/​saved-views/​settings/​teamOrganization/​OrganizationTeamOrganizationSetting.vue Deletes unused team-company visibility setting UI.
frontend/​src/​modules/​member/​components/​member-reach.vue Deletes unused member reach display.
frontend/​src/​modules/​member/​components/​member-last-activity.vue Deletes unused last-activity display.
frontend/​.eslint/​legacy-files.json Removes exemptions for deleted components.

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the unused-component cleanup.

No open issues 🎉

Review effort: Balanced

@gaspergrom
gaspergrom merged commit 4d72a97 into main Nov 14, 2026
14 checks passed
@gaspergrom
gaspergrom deleted the chore/issue-335-delete-dead-components-batch-2 branch November 14, 2026 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants