Repository navigation
chore: delete dead components, batch 2 (CM-1635) - #5312
Conversation
Refs linuxfoundation/lfx-cdp-insights-ops#335 Signed-off-by: Gašper Grom <gasper.grom@gmail.com>
PR SummaryLow Risk Overview ESLint legacy allowlists in Dropdown styling drops the unused Reviewed by Cursor Bugbot for commit 2213b52. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the unused-component cleanup.
No open issues 🎉
What changed in this PR
Removes nine unused Vue components from the CDP frontend, reducing legacy code without intended changes to the rendered UI.
Changes:
- Deletes unused member, organization-setting, shared, and UI-kit components.
- Removes the deleted password input’s Storybook stories and dropdown group-title styles.
- Cleans up ESLint legacy exemptions for deleted files.
| File | Description |
|---|---|
frontend/src/ui-kit/scrollcontroll/ScrollControll.vue |
Deletes unused scroll-event wrapper. |
frontend/src/ui-kit/lfx/dropdown/dropdown.scss |
Removes group-title styles and adjusts formatting. |
frontend/src/ui-kit/lfx/dropdown/dropdown-group-title.vue |
Deletes unused dropdown group title. |
frontend/src/ui-kit/input-password/InputPassword.vue |
Deletes unused password input. |
frontend/src/ui-kit/input-password/InputPassword.stories.ts |
Removes stories for the deleted input. |
frontend/src/shared/tag/tag-list.vue |
Deletes unused expandable tag list. |
frontend/src/shared/modules/entities/Entities.vue |
Deletes unused expandable entity wrapper. |
frontend/src/shared/loading/page-loader.vue |
Deletes unused loading indicator. |
frontend/src/modules/organization/config/saved-views/settings/teamOrganization/OrganizationTeamOrganizationSetting.vue |
Deletes unused team-company visibility setting UI. |
frontend/src/modules/member/components/member-reach.vue |
Deletes unused member reach display. |
frontend/src/modules/member/components/member-last-activity.vue |
Deletes unused last-activity display. |
frontend/.eslint/legacy-files.json |
Removes exemptions for deleted components. |
Review effort: Balanced
Deletes nine components nothing renders:
member-last-activity.vue,member-reach.vue,OrganizationTeamOrganizationSetting.vue,shared/loading/page-loader.vue,shared/modules/entities/Entities.vue,shared/tag/tag-list.vue, the ui-kitInputPassword(with its story),lfx/dropdown/dropdown-group-title.vueandScrollControll.vue.group-titlestyles fromdropdown.scssand the deleted files'legacy-files.jsonentries.Closes linuxfoundation/lfx-cdp-insights-ops#335