Skip to content

Configurable future carbs limit for Loop remote carbs - #823

Merged
marionbarker merged 2 commits into
devfrom
feature/loop-future-carbs
Nov 9, 2026
Merged

marionbarker merged 2 commits into
devfrom
feature/loop-future-carbs

Conversation

@bjorkert

@bjorkert bjorkert commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

How far ahead Loop remote carbs can be entered or edited is now set under Remote Settings → Meal Settings → Max Future Carbs, 1 hr by default (Loop's own limit), up to 4 hr. Users who build Loop with the Loop and Learn future_carbs_4h customization can set it to 4 hr; an unmodified Loop still rejects entries more than 1 hr ahead. The limit applies to new carbs and to editing logged carbs, and is included in the remote settings export.

Both this and #822 add a Loop Meal Settings section in Remote Settings, so whichever merges second needs the two pickers combined into one section.

Closes #815

remote_settings_future carbs_future_4h

How far ahead Loop remote carbs can be entered or edited is set in Remote Settings, 1 h by default, so it can match Loop built with the future_carbs_4h customization. The setting is included in the remote settings export.
@marionbarker

Copy link
Copy Markdown
Collaborator

Test

❌ This test failed.
I can edit carbs in the past and up to 1 hours in the future.
But even after changing setting to 4 hours in the future and even doing a quit/restart, followed by checking commit. I still cannot edit carbs: current time is 9:02, carb entry time is 12:52.

@marionbarker

Copy link
Copy Markdown
Collaborator

Test

✅ successful edit / delete of future carbs matching the limit set in LoopFollow
Configuration: commit 1b40c4c of feature/loop-future-carbs

@marionbarker marionbarker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve by code review and test

@marionbarker
marionbarker merged commit 393e808 into dev Nov 9, 2026
1 check passed
@marionbarker
marionbarker deleted the feature/loop-future-carbs branch November 9, 2026 16:53
kristinkand added a commit to kristinkand/LoopFollow that referenced this pull request Nov 11, 2026
loopandlearn#823 (configurable future carbs limit for Loop remote carbs) and loopandlearn#828 (the build workflow skips
fastlane's update check), both by Jonas Björkert.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UUzqfqfsM8BQYJ2yoRaLz8
kristinkand added a commit to kristinkand/LoopFollow that referenced this pull request Nov 11, 2026
loopandlearn#823 (configurable future carbs limit for Loop remote carbs) and loopandlearn#828 (the build workflow skips
fastlane's update check), both by Jonas Björkert.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UUzqfqfsM8BQYJ2yoRaLz8
kristinkand added a commit to kristinkand/LoopFollow that referenced this pull request Nov 11, 2026
loopandlearn#823 (configurable future carbs limit for Loop remote carbs) and loopandlearn#828 (the build workflow skips
fastlane's update check), both by Jonas Björkert.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UUzqfqfsM8BQYJ2yoRaLz8
kristinkand added a commit to kristinkand/LoopFollow that referenced this pull request Nov 11, 2026
…-exposed

loopandlearn#823 (configurable future carbs limit for Loop remote carbs) and loopandlearn#828 (the build workflow skips
fastlane's update check), both by Jonas Björkert.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UUzqfqfsM8BQYJ2yoRaLz8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants