Repository navigation
Add byte stream bounds to WebTransport stream types - #2596
Open
Martin Ferret (MartinFerret) wants to merge 1 commit into
Open
Martin Ferret (MartinFerret) wants to merge 1 commit into
Martin Ferret (MartinFerret) wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
Contributor
|
Looks reasonable, thanks! |
Contributor
Author
|
Thanks! You think I should fix the related properties in a follow-up PR? |
Contributor
|
LGTM |
Contributor
SGTM |
Contributor
|
Sorry Kagami Sascha Rosylight (@saschanaz), this PR has merge conflicts. They'll need to be fixed before this can be merged. |
Martin Ferret (MartinFerret)
force-pushed
the
fix-2439-webtransport-stream-types
branch
from
November 11, 2026 07:58
3423f1f to
0996d5d
Compare
Contributor
Author
|
Rebased on main, the conflicts are now fixed. Could you take another look when you have a minute? Thanks! |
Martin Ferret (MartinFerret)
force-pushed
the
fix-2439-webtransport-stream-types
branch
from
November 12, 2026 14:43
0996d5d to
446af8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2439
WebTransportReceiveStream,WebTransportSendStreamandWebTransportDatagramsWritableextended plainReadableStream/WritableStream, so their chunks wereany: reading gave youany, and you could write anything, even a string.I gave them proper bounds:
WebTransportReceiveStream extends ReadableStream<Uint8Array<ArrayBuffer>>WebTransportSendStream extends WritableStream<BufferSource>WebTransportDatagramsWritable extends WritableStream<BufferSource>This matches how byte streams are already typed in lib.dom (
Response.bodyfor reading,CompressionStream.writablefor writing), and the WebTransport spec, which rejects any chunk that isn't aBufferSource, for send streams and for datagrams.The change is a few lines in
inputfiles/patches/webtransport.kdl, with regenerated baselines. I also addedunittests/files/webtransport.ts: it checks the chunk types, that a string can't be written anymore, and that all three are still assignable toReadableStream/WritableStream. It fails without the patch.One thing I noticed: a few related properties in the same patch file still use plain streams (
WebTransportBidirectionalStream.readable/.writable, the return type ofcreateUnidirectionalStream(), andWebTransportDatagramDuplexStream.writable), so chunks there are stillany. I can update them here or in a follow-up, whichever you prefer.