Repository navigation
Add --disableDynamicImportExtensionRewriting - #65289
Merged
Andrew Branch (andrewbranch) merged 3 commits intoNov 3, 2026
Merged
Andrew Branch (andrewbranch) merged 3 commits into
Andrew Branch (andrewbranch) merged 3 commits into
Conversation
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Disabling dynamic-import extension rewriting still triggers erroneous helper diagnostics with importHelpers, potentially blocking output, and changing the option does not invalidate cached semantic diagnostics.
1 open issue
5 files not reviewed
tsc/internal/core/options_generated.go: Generated filetsc/internal/diagnostics/diagnostics_generated.go: Generated filetsc/internal/testrunner/options_generated.go: Generated filetsc/internal/tsoptions/declarations_generated.go: Generated filetsc/internal/tsoptions/options_generated.go: Generated file
What changed in this PR
Adds --disableDynamicImportExtensionRewriting to the native TypeScript compiler, allowing runtime extension rewriting to be disabled while retaining string-literal rewriting. This supports the content-mapper filtering planned in #65047.
Changes:
- Registers the option across compiler configuration, API types, schemas, and command-line help.
- Updates CommonJS and ES module transforms to respect the option.
- Adds compiler test variants and emit baselines for both option values.
| File | Description |
|---|---|
tsc/testdata/tests/cases/compiler/rewriteRelativeImportExtensionsDynamicImportCjs.ts |
Tests both option values with NodeNext CommonJS. |
tsc/testdata/tests/cases/compiler/disableDynamicImportExtensionRewriting.ts |
Adds import and require coverage across module modes. |
tsc/testdata/baselines/reference/tsc/commandLine/help-all.js |
Records the new option’s help text. |
tsc/testdata/baselines/reference/compiler/rewriteRelativeImportExtensionsDynamicImportCjs(disabledynamicimportextensionrewriting=true).js |
Records NodeNext output without runtime rewriting. |
tsc/testdata/baselines/reference/compiler/rewriteRelativeImportExtensionsDynamicImportCjs(disabledynamicimportextensionrewriting=false).js |
Records NodeNext output with runtime rewriting. |
tsc/testdata/baselines/reference/compiler/disableDynamicImportExtensionRewriting(disabledynamicimportextensionrewriting=true,module=preserve).js |
Records preserve-mode output with rewriting disabled. |
tsc/testdata/baselines/reference/compiler/disableDynamicImportExtensionRewriting(disabledynamicimportextensionrewriting=true,module=esnext).js |
Records ESNext output with rewriting disabled. |
tsc/testdata/baselines/reference/compiler/disableDynamicImportExtensionRewriting(disabledynamicimportextensionrewriting=true,module=commonjs).js |
Records CommonJS output with rewriting disabled. |
tsc/testdata/baselines/reference/compiler/disableDynamicImportExtensionRewriting(disabledynamicimportextensionrewriting=false,module=preserve).js |
Records preserve-mode output with rewriting enabled. |
tsc/testdata/baselines/reference/compiler/disableDynamicImportExtensionRewriting(disabledynamicimportextensionrewriting=false,module=esnext).js |
Records ESNext output with rewriting enabled. |
tsc/testdata/baselines/reference/compiler/disableDynamicImportExtensionRewriting(disabledynamicimportextensionrewriting=false,module=commonjs).js |
Records CommonJS output with rewriting enabled. |
tsc/internal/tsoptions/options_generated.go |
Adds parsing, merging, serialization, and emit/build tracking. |
tsc/internal/tsoptions/declarations_generated.go |
Registers the command-line option. |
tsc/internal/transformers/moduletransforms/esmodule.go |
Gates runtime rewriting in ES module output. |
tsc/internal/transformers/moduletransforms/commonjsmodule.go |
Gates runtime rewriting in CommonJS output. |
tsc/internal/testrunner/options_generated.go |
Enables test variations for the option. |
tsc/internal/diagnostics/diagnostics_generated.go |
Adds the generated help message. |
tsc/internal/diagnostics/diagnosticMessages.json |
Defines the option’s help message. |
tsc/internal/diagnostics/diagnosticMessages.generated.json |
Adds the generated message catalog entry. |
tsc/internal/core/options_generated.go |
Adds option storage, cloning, and equality checks. |
tools/scripts/tsc/options.ts |
Defines option metadata and ordering. |
packages/typescript/src/api/proto.generated.ts |
Exposes the option in raw API types. |
packages/typescript/src/api/compilerOptions.generated.ts |
Exposes the option in compiler API types. |
packages/typescript/schemas/tsconfig.schema.json |
Adds TypeScript configuration schema support. |
packages/typescript/schemas/jsconfig.schema.json |
Adds JavaScript configuration schema support. |
Review effort: Balanced
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the new option to disable dynamic-import extension rewriting.
No open issues 🎉
1 resolved since last review
5 files not reviewed
tsc/internal/core/options_generated.go: Generated filetsc/internal/diagnostics/diagnostics_generated.go: Generated filetsc/internal/testrunner/options_generated.go: Generated filetsc/internal/tsoptions/declarations_generated.go: Generated filetsc/internal/tsoptions/options_generated.go: Generated file
Review effort: Balanced
Andrew Branch (andrewbranch)
requested a review
from Ryan Cavanaugh (RyanCavanaugh)
November 3, 2026 21:07
Member
|
We're using |
Member
Author
|
It was a previous oversight. Fixed in the latest commit. |
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Nov 3, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change adding an option to disable runtime dynamic-import extension rewriting.
No open issues 🎉
5 files not reviewed
tsc/internal/core/options_generated.go: Generated filetsc/internal/diagnostics/diagnostics_generated.go: Generated filetsc/internal/testrunner/options_generated.go: Generated filetsc/internal/tsoptions/declarations_generated.go: Generated filetsc/internal/tsoptions/options_generated.go: Generated file
Review effort: Balanced
Andrew Branch (andrewbranch)
enabled auto-merge
November 3, 2026 21:54
Andrew Branch (andrewbranch)
deleted the
disableDynamicImportExtensionRewriting
branch
November 3, 2026 22:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--disableDynamicImportExtensionRewritingdisables emission of the emit helper that rewrites file extensions in non-literal 'import()' and 'require()' calls when--rewriteRelativeImportExtensionsis enabled.Prerequisite for #65047