[JoshLove01]

Summary

• remove back-compat-based filtering of generated Obsolete attributes from types, properties, existing methods, and restored methods
• apply the current API deprecation state regardless of whether the previous contract was obsolete
• preserve custom and last-visitor Obsolete precedence while preventing duplicate attributes

Testing

• TypeProviderTests: 191 passed
• Microsoft.TypeSpec.Generator.ClientModel.Tests: 2,780 passed

[pkg-pr-new]

Open in StackBlitz

npm i https://pkg.pr.new/@typespec/http-client-csharp@12573

commit: bd50690

[github-actions]

No changes needing a change description found.

[Copilot]

🟡 Changes recommended

Obsolete-attribute reconciliation can leave duplicate attributes that break SDK compilation, and existing ClientModel tests still assert the removed behavior.

2 open issues

• Reconcile obsolete attributes after visitors on every type · New
• ClientModel tests still expect obsolete attributes to be removed · New

What changed in this PR

This PR updates the C# client generator so backward-compatible methods retain current deprecation metadata rather than inheriting the previous contract’s obsolete status.

Changes:

• Apply current Obsolete attributes to restored overloads and reordered methods.
• Prefer visitor-supplied deprecation attributes over generated attributes.
• Update provider tests to expect current deprecation messages.

File	Description
packages/​http-client-csharp/​generator/​Microsoft.TypeSpec.Generator/​test/​Providers/​TypeProviderTests.cs	Updates deprecation expectations for restored and reordered methods.
packages/​http-client-csharp/​generator/​Microsoft.TypeSpec.Generator/​src/​Utilities/​BackCompatHelper.cs	Copies current deprecation metadata to restored overloads.
packages/​http-client-csharp/​generator/​Microsoft.TypeSpec.Generator/​src/​Providers/​TypeProvider.cs	Replaces prior-contract deprecation filtering with visitor-attribute precedence.

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Visitor Obsolete reconciliation is skipped for clients without a prior contract, leaving duplicate attributes that cause compiler error CS0579.

2 open issues

• ClientModel tests still expect obsolete attributes to be removed
• Reconcile obsolete attributes after visitors on every type

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

Repeated visitor-supplied Obsolete attributes remain duplicated on restored overloads, causing CS0579 compilation failures, and the regression test omits the main visitor pass that exposes the issue.

1 open issue

• Deduplicate visitor-supplied Obsolete attributes on restored overloads · New

2 resolved since last review

• ClientModel tests still expect obsolete attributes to be removed
• Reconcile obsolete attributes after visitors on every type

_{Review effort: Balanced}

[Copilot]

🔵 Needs a closer look

Restored overloads can retain duplicate visitor-added attributes under the actual generation order, causing CS0579 compilation errors that the current regression does not cover.

1 open issue

• Deduplicate visitor-supplied Obsolete attributes on restored overloads

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The restored overload can expose a different deprecation message or DiagnosticId because it selects the first visitor-added Obsolete attribute while the current method keeps the last, and the regression test cannot detect this mismatch.

1 open issue

• Preserve the last Obsolete attribute when restoring overloads · New

1 resolved since last review

• Deduplicate visitor-supplied Obsolete attributes on restored overloads

_{Review effort: Balanced}

[Copilot]

🟡 Changes recommended

The regression test’s filter excludes restored overloads from visitor attribute updates, leaving duplicate-attribute reconciliation on those overloads untested.

1 open issue

• Match restored overloads by signature so visitors append attributes · New

1 resolved since last review

• Preserve the last Obsolete attribute when restoring overloads

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are reported for the C# generator changes aligning deprecation metadata with the current API contract.

No open issues 🎉

1 resolved since last review

• Match restored overloads by signature so visitors append attributes

_{Review effort: Balanced}

[Copilot]

🟢 Approval recommended

No active review issues are reported for the deprecation-handling changes.

No open issues 🎉

_{Review effort: Balanced}