Repository navigation
[python] release new version - #12579
Closed
Libba Lawrence (l0lawrence) wants to merge 2 commits into
Closed
Libba Lawrence (l0lawrence) wants to merge 2 commits into
Libba Lawrence (l0lawrence) wants to merge 2 commits into
Conversation
Revert the implementation of #12484 while preserving Python emitter 0.40.1 and its current dependency upgrades. Record this rollback as an internal change without a version bump. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Libba Lawrence (l0lawrence)
requested review from
Chenxi Jiang (ChenxiJiang333),
catalinaperalta,
iscai-msft,
Kashif Khan (kashifkhan),
Laurent Mazuel (lmazuel),
Mark Cowlishaw (markcowl),
Yuchao Yan (msyyc),
Chenjie Shi (tadelesh),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
November 13, 2026 18:22
microsoft-github-policy-service
Bot
added
the
emitter:client:python
commit: |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing the browser-emission tests leaves the restored micropip.install path unverified, including the generator-wheel URL, rejected-installation diagnostics, and successful retry on the next emit.
1 open issue
What changed in this PR
Retries publishing @typespec/http-client-python 0.40.1 without changing its version. The current diff also includes #12577’s playground-wheel rollback; after that PR merges, this retry is intended to contain only the pipeline comment.
Changes:
- Adds a pipeline comment to retrigger publication.
- Reverts bundled browser dependencies and restores micropip installation.
- Removes rollback-specific tests and documentation, and records the rollback in Chronus.
| File | Description |
|---|---|
packages/http-client-python/tests/unit/test_browser_wheels.py |
Removes bundled-wheel build tests. |
packages/http-client-python/package.json |
Removes the playground build script and bundled dependency assets. |
packages/http-client-python/eng/scripts/setup/build.ts |
Stops forwarding playground build arguments. |
packages/http-client-python/eng/scripts/setup/build_pygen_wheel.py |
Removes browser dependency wheel preparation. |
packages/http-client-python/eng/pipeline/publish.yml |
Adds the release-trigger comment and removes the playground build override. |
packages/http-client-python/emitter/test/browser-pyodide.test.ts |
Removes manifest-loading and initialization failure tests. |
packages/http-client-python/emitter/src/emitter.ts |
Restores browser installation through micropip. |
packages/http-client-python/ARCHITECTURE.md |
Removes bundled browser-wheel documentation. |
.chronus/changes/python-playground-wheel-rollback.md |
Records the playground-wheel rollback. |
Review effort: Balanced
Comment on lines
+309
to
+311
| await pyodide.loadPackage("micropip"); | ||
| const micropip = pyodide.pyimport("micropip"); | ||
| await micropip.install(getBrowserPygenWheelUrl()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retries publishing
@typespec/http-client-python0.40.1. #12556 set the version to 0.40.1, but it was not published.This branch is based on #12577, which reverts #12484's bundled playground wheels and the
build:playgroundpublish override. Merge #12577 first, then update this branch frommainif needed so this PR contains only the release-trigger change.The release change adds a comment to
packages/http-client-python/eng/pipeline/publish.ymlso the publish pipeline runs again when it merges. The version stays at 0.40.1, with no CHANGELOG or new Chronus entries. Check whether #12577's merge has already published 0.40.1 before merging this retry.Supersedes #12578, whose branch was in a fork.