Repository navigation
♻️ use hashes for request parameters - #280
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Enqueue requests fail because the multipart hash uses symbol field names and incorrectly structures file uploads; string-named tuples with a three-element file tuple are required.
1 open issue
What changed in this PR
This PR standardizes V2 search and extraction parameters as symbol-keyed hashes and updates the HTTP enqueue path to consume the shared request_parameters interface.
Changes:
- Replace product form-data mutation with parameter hashes.
- Align search parameters, type signatures, and documentation with symbol keys.
- Add tests for search and extraction parameter serialization.
| File | Description |
|---|---|
spec/v2/search/rag_document_search_spec.rb |
Tests RAG document request parameters. |
spec/v2/search/model_search_spec.rb |
Tests model search request parameters. |
spec/v2/product/extraction/extraction_parameter_spec.rb |
Tests extraction parameter serialization. |
sig/mindee/v2/search/rag_documents/rag_document_search_parameters.rbs |
Declares symbol-keyed search parameters. |
sig/mindee/v2/search/models/model_search_parameters.rbs |
Declares symbol-keyed model parameters. |
sig/mindee/v2/product/extraction/params/extraction_parameters.rbs |
Replaces the form-data method signature. |
sig/mindee/v2/http/mindee_api_v2.rbs |
Updates the request-parameter interface. |
sig/mindee/v2/client_options/base_search_parameters.rbs |
Updates the base search return type. |
sig/mindee/v2/client_options/base_product_parameters.rbs |
Declares the new product parameter method. |
lib/mindee/v2/search/rag_documents/rag_document_search_parameters.rb |
Uses symbol keys for document filters. |
lib/mindee/v2/search/models/model_search_parameters.rb |
Uses symbol keys for model filters. |
lib/mindee/v2/product/extraction/params/extraction_parameters.rb |
Returns extraction options as a hash. |
lib/mindee/v2/http/mindee_api_v2.rb |
Builds enqueue data from parameter hashes. |
lib/mindee/v2/client_options/base_search_parameters.rb |
Uses symbol keys for pagination. |
lib/mindee/v2/client_options/base_product_parameters.rb |
Returns shared product parameters as a hash. |
Review effort: Balanced
ianardee
force-pushed
the
update-params
branch
from
November 9, 2026 14:34
16c90a2 to
78c198a
Compare
ianardee
force-pushed
the
update-params
branch
from
November 9, 2026 14:46
78c198a to
fa8c9d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Types of changes