Repository navigation
ci(github-action): update action misospace/pr-reviewer-action (v3.9.0 → v3.10.0) - #538
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
{"schema":"review-handoff/v1","review_id":"f1aad02557dea0bd","head_sha":"15828475f474a3f909ae38c7ea66b6034e8c5ca1","verdict":"approve","review_result":"clean","required_checks":"none","items":[],"items_total":0,"items_truncated":false,"unresolved_requirement_ids":[],"unresolved_requirement_ids_total":0,"unresolved_requirement_ids_truncated":false,"unresolved_requirement_ids_source_total":0,"unresolved_required_checks":[],"unresolved_required_checks_total":0,"unresolved_required_checks_truncated":false,"unresolved_required_checks_source_total":0,"unresolved_review_obligations":[],"unresolved_review_obligations_total":0,"unresolved_review_obligations_truncated":false,"derived_obligation_state":null}AI Automated Review
✅ Automated recommendation: APPROVE
Full PR review.
Analysis engine: MiniMax-M3.1-Flash (anthropic) — primary route · pr-reviewer-action v3.10.0
Recommendation: approve the pinned pr-reviewer-action v3.10.0 update; no merge-blocking defect is established by the available evidence.
Change Review
.github/workflows/ai-pr-review.yaml:72replaces the old action commit with3d354d4ccf6ccdeaf1ad7a9547775426f25a0216, and GitHub’s tag API resolves that commit fromv3.10.0.- The workflow’s permissions and fork trust boundary are unchanged, and the reported CI checks pass at the reviewed head.
Claims to Falsify
- Claim 1: unverified (0/1 held); the Helm configuration is upstream and was not semantically inspected.
- Claim 2: unverified (0/1 held); the publishing workflow’s branch, tag, and fork behavior was not inspected beyond release metadata.
- Claim 3: unverified (0/1 held); exact-tag filtering and image aliases were not inspected in the workflow source.
- Claim 4: unverified (0/1 held); the guarded retag script and superseded-run behavior were not inspected.
- Claim 5: unverified (0/1 held); chart
version/appVersionequality was not inspected.
Tool Harness Findings
- The harness verified the v3.10.0 tag-to-commit mapping and located the updated pin, but its upstream investigation ended with a request error; missing source evidence remains unverified rather than failed.
Sources
- PR diff; GitHub tags API for
v3.10.0; upstream v3.10.0 release/compare metadata; repository workflow-security skill; head CI results.
Unknowns or Needs Verification
- Upstream tests or source at the pinned commit are needed to establish the confirmation-round and publishing invariants, and upstream chart defaults are needed to verify the Helm behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
v3.9.0→v3.10.0Release Notes
misospace/pr-reviewer-action
v3.10.0Compare Source
3.10.0 is about running it for real. The self-hosted controller has been code for two releases; this is the one that becomes installable. Controller and worker images now publish from every merge and release, the Helm chart ships as a versioned OCI artifact at the same coordinate as the release, polling discovers open PRs without a webhook, and a cluster install no longer needs hand-repaired claim roots, guessed NetworkPolicy CIDRs, or a service-account token the pinned chart library silently ignored. Most of those fixes came from the first operator pilot hitting them.
The same pilot produced the enforcement fixes. Reviews this action ran on its own changes exposed places where the deterministic side was wrong: dependency provenance credited a same-named repository instead of the registry document, a satisfied runtime row lost approval over serialization bookkeeping, a child PR inherited its umbrella parent's acceptance criteria, and an unexplained
unknowncould block without saying what was missing. If you only run the GitHub Action, that section is your release; no Action input was added, removed, or given a new default.The operator stack becomes a release artifact
pr-<number>(moving) andsha-<commit>(immutable);mainpushes getsha-<commit>; release tags get the release alias plussha-<commit>; fork PRs build and validate both targets but publish nothing, withcontents: readonly. Before any push the workflow resolves eachsha-<commit>tag, so an existing immutable tag is never overwritten and the run summary reports the exact digest it reused or built.X.Y.Zandsha-<commit>only — nolatest, no floatingX.Y, no major alias — and the floatingv3git tag no longer starts a doomed publish run.oci://ghcr.io/misospace/charts/pr-reviewer:X.Y.Z, with chartversionandappVersionequal to the application release. The publish job refuses a tag/version/manifest disagreement and never replaces an already-published chart version; there is nolatestchart alias.pgrep/pkillfromprocps, which the subprocess boundary requires before it will launch anything; without it acquisition failed atgit init --bare. A refused spawn is now reported with bounded, masked diagnostics instead ofexited unknown.Discovery stops depending on webhooks
controller.reconcile.enableddefaults true and the interval defaults to 15 minutes.repos: []stays the safe default, so nothing is polled until an operator names targets; webhooks remain optional low-latency hints. Initial rollout lists every currently open PR, not just PRs created after installation.installation.idis repaired from the configured App installation, or refused with a fixed200 {"status":"ignored"}when none is configured. Repairs and refusals are counted on/admin/diagnosticsand rendered by the dashboard.The chart survives a real cluster
networkPolicy.enableddefault is nowfalse, after the pilot hit repeated runtime breakage from default-on policies. Explicit opt-in behavior is unchanged.fix-rootsinit container chowns the runs and workspace-cache roots to uid 1000, group 65532, andchmod 2750before the controller starts. The runtime's own trust check refuses group-writable roots, so without this every Kubernetes-executor job failed before dispatch.fix-rootsrenders in every executor mode, with0750and no setgid for controller-only because the local executor never crosses uid. Operator consequence: the pod now needs a Pod Securitybaselinenamespace even for controller-only installs.networkPolicy.workerAdditionalEgressextends the worker policy only, so an in-cluster HTTP model endpoint is reachable while the controller policy is unchanged. An exception with no rendered worker policy refuses the render. The deployment runbook also documents the Kubernetes API egress exception Cilium kube-proxy-replacement clusters need (#1738, closes #1714).podOptionskey, which the pinned 5.x library ignores; with automount off, the executor's in-cluster identity check refused startup. The chart now uses the 5.xpodkey.PR_REVIEWER_CREDENTIAL_MODEL-KEYwhile the runtime read..._MODEL_KEY, so every hyphenated credential reference failed startup. The chart derivation now applies the same uppercase/non-alphanumeric rule ascredentialEnvName.default-evidence-profilewas null, even though the instance schema allows it and the forced profile was never consumed. It now starts with evidence not configured, matching Action mode.GitLab groundwork
platform: gitlabis a declared platform with merge-request webhook authentication (Standard Webhooks HMAC orX-Gitlab-Token),refs/merge-requests/<iid>/headacquisition, and publication through notes, discussions, and commit statuses. The adapters are in place, but the controller daemon still refuses a GitLab instance at startup until the durable lane is composed (#1677), and a resolved GitLab run on the Action host is refused rather than falling back to GitHub. Nothing for an operator to run yet.Review correctness found by dogfooding
registry.npmjs.orgpackument or versioned manifest, ornpmjs.com/www.npmjs.compackage pages). Runs that refuse those hosts keep the row fail-closed unresolved; add the hosts toallowed-source-hostsif you want settlement.gh_apilookups are now attributed like web lookups, receipts from both channels count, and a validated ledger that covers every obligation settles the row withdependency-evidenceinstead of losing it when the verdict failed to echo check text. The reserve window releases, so the loop can stop before burning the whole budget. Confirmed negatives and mismatched versions still stay unresolved.Testsortest (24)job, or a test step in a combinedTypecheck, lint, test, buildname, now proves a full-suite required check. Scope and disqualifier vetoes still apply, and truncation drift still refuses the whole artifact.proof_shape_mismatchand keeps the reviewer's judgment. A fabricated, stale, or out-of-range citation still stays material, and atest_requiredrow without a resolvable test citation still blocks.unverifiablerow that the reviewer left without a reason now carries a bounded deterministic reason naming what was not verified. The row remains material; the published trace is no longer blank where the reviewer declined to conclude.investigation-completeis model-confirmed (#1735, closes #1729): satisfying the coverage gate with budget left now arms a confirmation round instead of stopping; only the model's no-tool reply on that round selects the stop. A covered run with no slot left reports the ordinary budget/round exhaustion stop, and an unanswerable verification question must say why the available tools cannot settle it.Upgrading
Pin to
v3.10.0, or the floatingv3tag, which now follows this build. Immutable-version and SHA pins must be bumped deliberately.No Action input was added, removed, or given a new default. The honest notes:
allowed-source-hostscan no longer settle the provenance row from a GitHub lookup, and the obligation stays unresolved. Addregistry.npmjs.org,npmjs.com,www.npmjs.comtoallowed-source-hoststo keep settlement. This is deliberately fail-closed.Testsor combined test CI check now counts as a full-suite check. Invalid citations, missing test citations, and confirmed negatives still block.tool-call-budget-exhausted/max-roundsinstead ofinvestigation-complete. Expect one extra model request on some runs.networkPolicy.enabledis nowfalse; installs that relied on the default-on policies must set it totrue. Polling is enabled by default but does nothing untilcontroller.reconcile.reposis set; when set, it fetches every open PR, not just new ones. Controller-only installs now render afix-rootsinit container and therefore need a Pod Securitybaselinenamespace.controller.reconcile.githubInstallationId(orPR_REVIEWER_GITHUB_APP_INSTALLATION_ID) if your deliveries can arrive withoutinstallation.id; without it, a delivery that would mint a job is ignored rather than queued to fail authentication. The value is now emitted whenever set, even with polling disabled.X.Y.Zorsha-<commit>; there is nolatest,X.Y, or major image tag. PR builds usepr-<number>(moving) andsha-<commit>(immutable). The chart OCI artifact follows the sameX.Y.Zcoordinate.platform: gitlabis accepted for configuration and adapter tests, but both the controller daemon and the Action host refuse a GitLab run until #1677 composes the durable lane.Every input's current contract lives in docs/inputs.md.
Full changelog: misospace/pr-reviewer-action@v3.9.0...v3.10.0
Generated changelog (release-please)
Features
Bug Fixes
investigation-complete(#1735) (99c4377)Chores
Documentation
Configuration
📅 Schedule: (in timezone America/Edmonton)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Operator.