Repository navigation
Conversation
## Motivation and Context `_meta` is an object on every request (`MetaObject` in the schema). After modelcontextprotocol#650, a String, Array, or number there no longer raises from `dig`, and the modern lifecycle answers -32602 because the envelope keys are missing; the legacy lifecycle, though, went on to run the handler. That left two gaps. The value still reached `server_context[:_meta]`, where the `server_context.dig(:_meta, ...)` the server context page shows raises `TypeError` on a String or an Array, so a handler written as documented still turned the request into -32603. And the TypeScript and Python servers refuse such a request as invalid params on both lifecycles, through schema validation of `params` and their inbound checks, so the Ruby server answered differently from both. The request is now refused with -32602 "Invalid params: _meta must be an object" before the envelope is read and before any handler runs, on both lifecycles. A notification handed to a handler is dropped the same way, without a response, as the TypeScript server drops a notification with invalid params; `notifications/cancelled` is served before the check and reads no `_meta`. A `null` `_meta` reads as absent, as it does for the Python server's request model. The server context page states the rule, since it tells handlers to read `_meta` from `server_context`. ## How Has This Been Tested? test/mcp/server_test.rb and test/mcp/server/transports/streamable_http_transport_test.rb. Before the fix, legacy `tools/call` with `_meta: "not-an-object"` ran the tool, and a tool reading `server_context.dig(:_meta, :key)` answered -32603 "Internal error" with "Internal error calling tool meta_reader" as the data. ## Breaking Changes A legacy-lifecycle request whose `_meta` is not an object now answers -32602. Released versions served such a request for methods that never read `_meta`, such as `tools/list`, and answered -32603 for `tools/call` and `prompts/get`.
atesgoral
approved these changes
Nov 2, 2026
koic
deleted the
refuse_a_meta_that_is_not_an_object_as_invalid_params
branch
November 3, 2026 08:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
_metais an object on every request (MetaObjectin the schema). After #650, a String, Array, or number there no longer raises fromdig, and the modern lifecycle answers -32602 because the envelope keys are missing; the legacy lifecycle, though, went on to run the handler. That left two gaps. The value still reachedserver_context[:_meta], where theserver_context.dig(:_meta, ...)the server context page shows raisesTypeErroron a String or an Array, so a handler written as documented still turned the request into -32603. And the TypeScript and Python servers refuse such a request as invalid params on both lifecycles, through schema validation ofparamsand their inbound checks, so the Ruby server answered differently from both.The request is now refused with -32602 "Invalid params: _meta must be an object" before the envelope is read and before any handler runs, on both lifecycles. A notification handed to a handler is dropped the same way, without a response, as the TypeScript server drops a notification with invalid params;
notifications/cancelledis served before the check and reads no_meta. Anull_metareads as absent, as it does for the Python server's request model. The server context page states the rule, since it tells handlers to read_metafromserver_context.How Has This Been Tested?
test/mcp/server_test.rb and test/mcp/server/transports/streamable_http_transport_test.rb. Before the fix, legacy
tools/callwith_meta: "not-an-object"ran the tool, and a tool readingserver_context.dig(:_meta, :key)answered -32603 "Internal error" with "Internal error calling tool meta_reader" as the data.Breaking Changes
A legacy-lifecycle request whose
_metais not an object now answers -32602. Released versions served such a request for methods that never read_meta, such astools/list, and answered -32603 fortools/callandprompts/get.Types of changes
Checklist