Repository navigation
fix: deploy page - #141
fix: deploy page#141
Conversation
aceforeverd
commented
Nov 16, 2026
- Narrowed prefilling to only the prefill requests: const prefilling = loading || entry.isFetching || preview.fetching;
- Unblocked routeOptions so it starts as soon as seedPlan (releasePlan) arrives instead of waiting for upgradeSeed.
- override yaml should only can /api/v2/compose?dryRun=true once
• Narrowed prefilling to only the prefill requests:
const prefilling = loading || entry.isFetching || preview.fetching;
• Unblocked routeOptions so it starts as soon as seedPlan (releasePlan) arrives instead of waiting for upgradeSeed.
override yaml should only can /api/v2/compose?dryRun=true once
huskcass
left a comment
There was a problem hiding this comment.
Blockers: none. CI green (go, web, gate).
Medium
- Override YAML dedupe is built twice.
loadHelmValues+HelmValuesInflight+helmValuesMutationOptions+ thevaluesInflightref in DeploySheet, plus a secondloadingRefguard in OverrideDialog, all stop the same double call.mutationFnalso ignores its_keyargument and readsgetRequest()!. AuseQuery({ queryKey: ["helm-values", valuesKey], enabled: opened && canDiscover })dedupes StrictMode and concurrent loads on its own. That drops the inflight type, the ref, the loadingRef and the mutation plumbing. If the mutation stays, keep only one of the two guards. - The
pollprop is threaded through InferenceDetail, Overview, Logs, Events, Runs, RunsTable and useAutoscaling just to pause refetching behind the upgrade sheet. Those requests are cheap and the sheet is modal, so I'd cut this. If you keep it, pausing at the query-client level (or only on the list and detail status queries) avoids touching seven components' props. prefillingincludesentry.isFetching, so choosing a different variant or version inside the form turns the whole fieldset inert (focus lost, opacity 60) on every target change, not just on first load. Check that this is intended; otherwise freeze only until the first seed completes.
Low
disabled+inert+aria-busy+pointer-events-noneall on the fieldset:disabledandinertalready cover the behavior. Droppointer-events-none/select-noneunless a control escapes them.- The new
DeployFormtest asserts attribute order with a regex on static markup, which is brittle. Test thedisabledandinertattributes separately.
Solid
keepPreviousDatatogether with!entry.isPlaceholderDatainseedReadyandcanDiscoveravoids seeding or discovering from the previous variant.- Starting
routeOptionsfromseedPlanremoves the serial wait onupgradeSeed. retry: falseon the catalog queries stops error spinners from lingering.
Verdict: no blockers; good to merge after considering the dedupe simplification above.
— Review Golden
huskcass
left a comment
There was a problem hiding this comment.
No blockers.
useReleaseEvents now uses usePollOptions, so Events and the Overview events card pause behind the sheet. Every page query that polls behind the upgrade and install sheets (list, status, objects, autoscaling, runs, pods, logs, events) goes through the shared pause, and Catalog and Model pages do not poll. The Override YAML dedupe is now one useQuery: the inflight ref, mutation and loadingRef are gone. The poll props are gone from Overview, Logs, Events, Runs and RunsTable. typecheck and 704 tests pass.
- Low (cut):
!upgrading && !pausedin InferenceDetail and InferenceList. The sheet'susePausePollingalready setspausedwhenever an upgrade target is open, soupgradingcan go. - Low (cut): the
releasedflag andMath.max(0, …)inpausePollingguard a double release that the effect cleanup never does. - Low (still open):
pointer-events-none select-noneon the fieldset besidedisabled+inert, and the attribute-order regex in DeployForm.test.tsx:490.
Verdict: good to merge.
— Review Golden