Skip to content

fix: deploy page - #141

Merged
aceforeverd merged 6 commits into
mainfrom
fix-deploy-page
Nov 16, 2026
Merged

aceforeverd merged 6 commits into
mainfrom
fix-deploy-page

Conversation

@aceforeverd

Copy link
Copy Markdown
Member
  • Narrowed prefilling to only the prefill requests: const prefilling = loading || entry.isFetching || preview.fetching;
  • Unblocked routeOptions so it starts as soon as seedPlan (releasePlan) arrives instead of waiting for upgradeSeed.
  • override yaml should only can /api/v2/compose?dryRun=true once

  • Narrowed prefilling to only the prefill requests:
    const prefilling = loading || entry.isFetching || preview.fetching;

  • Unblocked routeOptions so it starts as soon as seedPlan (releasePlan) arrives instead of waiting for upgradeSeed.
override yaml should only can /api/v2/compose?dryRun=true once
@aceforeverd aceforeverd changed the title Fix deploy page fix: deploy page Nov 16, 2026
@aceforeverd
aceforeverd requested a review from huskcass November 16, 2026 08:15

@huskcass huskcass left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blockers: none. CI green (go, web, gate).

Medium

  • Override YAML dedupe is built twice. loadHelmValues + HelmValuesInflight + helmValuesMutationOptions + the valuesInflight ref in DeploySheet, plus a second loadingRef guard in OverrideDialog, all stop the same double call. mutationFn also ignores its _key argument and reads getRequest()!. A useQuery({ queryKey: ["helm-values", valuesKey], enabled: opened && canDiscover }) dedupes StrictMode and concurrent loads on its own. That drops the inflight type, the ref, the loadingRef and the mutation plumbing. If the mutation stays, keep only one of the two guards.
  • The poll prop is threaded through InferenceDetail, Overview, Logs, Events, Runs, RunsTable and useAutoscaling just to pause refetching behind the upgrade sheet. Those requests are cheap and the sheet is modal, so I'd cut this. If you keep it, pausing at the query-client level (or only on the list and detail status queries) avoids touching seven components' props.
  • prefilling includes entry.isFetching, so choosing a different variant or version inside the form turns the whole fieldset inert (focus lost, opacity 60) on every target change, not just on first load. Check that this is intended; otherwise freeze only until the first seed completes.

Low

  • disabled + inert + aria-busy + pointer-events-none all on the fieldset: disabled and inert already cover the behavior. Drop pointer-events-none/select-none unless a control escapes them.
  • The new DeployForm test asserts attribute order with a regex on static markup, which is brittle. Test the disabled and inert attributes separately.

Solid

  • keepPreviousData together with !entry.isPlaceholderData in seedReady and canDiscover avoids seeding or discovering from the previous variant.
  • Starting routeOptions from seedPlan removes the serial wait on upgradeSeed.
  • retry: false on the catalog queries stops error spinners from lingering.

Verdict: no blockers; good to merge after considering the dedupe simplification above.

— Review Golden

@huskcass huskcass left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No blockers.

useReleaseEvents now uses usePollOptions, so Events and the Overview events card pause behind the sheet. Every page query that polls behind the upgrade and install sheets (list, status, objects, autoscaling, runs, pods, logs, events) goes through the shared pause, and Catalog and Model pages do not poll. The Override YAML dedupe is now one useQuery: the inflight ref, mutation and loadingRef are gone. The poll props are gone from Overview, Logs, Events, Runs and RunsTable. typecheck and 704 tests pass.

  • Low (cut): !upgrading && !paused in InferenceDetail and InferenceList. The sheet's usePausePolling already sets paused whenever an upgrade target is open, so upgrading can go.
  • Low (cut): the released flag and Math.max(0, …) in pausePolling guard a double release that the effect cleanup never does.
  • Low (still open): pointer-events-none select-none on the fieldset beside disabled + inert, and the attribute-order regex in DeployForm.test.tsx:490.

Verdict: good to merge.

— Review Golden

@aceforeverd
aceforeverd merged commit 5c4a888 into main Nov 16, 2026
4 checks passed
@aceforeverd
aceforeverd deleted the fix-deploy-page branch November 16, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants