Repository navigation
swiss: site profile inputs are a list of {key, value} - #142
Merged
Merged
Conversation
swissd now serves the site profile's inputs as [{key, value}], the shape of
the catalog's inputs and the inputs annotation. Lookups go by key, the
profile pages list the entries, and remembering an answer for the site
updates or appends an entry in the profile's inputs list.
Co-authored-by: aceforeverd <11715200+aceforeverd@users.noreply.github.com>
huskcass
commented
Nov 16, 2026
huskcass
left a comment
Collaborator
Author
There was a problem hiding this comment.
No blockers.
- Low:
siteAnswers.tswithSiteAnswers: the secondif (!isSeq(list)) throwcannot fire right after settinginputsto[].saveSiteAnswersalready throws on a profile that fails to parse, so the old map form never gets here. Fold it into oneisSeqcheck, or cast. - Checked: every reader of site inputs (
inputRowsprefill,filledSiteAnswersforplanRequest's typed > release > site > default, both profile pages, both profile forms,deployment-settings) now looks entries up by key, and the YAML edit appends or updates by key with comments kept. This matches swiss#66's[{key, value}]. Typecheck clean, 705 tests pass.
LGTM, merge together with swiss#66.
— Review Golden
aceforeverd
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swissd serves the site profile's
inputsas a list of{key, value}(modelsphere/swiss#66), so a key likevolumes.[name=draft-model].hostPath.pathis a plain string value:SiteProfile.inputsisSiteInput[]({key, value}, value a string, number or boolean). Site answers are looked up by key;siteInputstakes the list.inputslist, or appends one, keeping comments and other lines.Must merge together with modelsphere/swiss#66.
Refs modelsphere/modelsphere#75.