Repository navigation
Remove stale deploy configuration notes about Sentry token - #7496
Merged
suhaibmujahid merged 1 commit intoNov 14, 2026
Merged
Conversation
Remove outdated GitHub setup requirements from the workflow and the Sentry token reference from the deployment README.
There was a problem hiding this comment.
🟡 Changes recommended
Removing the missing-token guard causes versioned promotions to fail after production is updated when SENTRY_AUTH_TOKEN is unset, making optional Sentry reporting a deployment failure.
What changed in this PR
This PR cleans up stale configuration guidance for Hackbot production deployments. It also removes a runtime check, so the changes are not documentation-only.
Changes:
- Remove GitHub setup requirements from workflow comments.
- Remove the README’s reference to the environment-specific Sentry token.
- Remove the missing-token skip before Sentry deployment reporting.
| File | Description |
|---|---|
| tools/hackbot-deploy/README.md | Removes the Sentry token configuration reference. |
| .github/workflows/hackbot-prod-deploy.yml | Removes setup comments and the missing-token guard for Sentry reporting. |
Review effort: Balanced
| echo "::warning::No SENTRY_AUTH_TOKEN secret in hackbot-prod-services; the production deploy isn't marked in Sentry." | ||
| exit 0 | ||
| fi | ||
| version=$(jq -r '.version // empty' <<< "$PROMOTION") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove outdated GitHub setup requirements from the workflow and the Sentry token reference from the deployment README.