Repository navigation
chore(ci): name the actual tag in the version-matrix pin comments - #2129
Merged
Merged
Conversation
All six workflows pin icewind1991/nextcloud-version-matrix to cd0211ffcef1065e2020cd579e4843b8746e7a58, which is tag v1.3.3. Four of the comments read v1.3.3.3.1.3.3, two read v1.0.0. v1.0.0 is c2bf575a3516752db5ce2915499d3f694885e2c7 and is not used here. Comments only; the pinned commit is unchanged. Assisted-by: Claude Code:claude-opus-5[1m] Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
1 task done
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
AndyScherzinger
deleted the
chore/noid/fix-version-matrix-tag-comments
branch
November 11, 2026 23:16
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1967, where @Croydon pointed out in #1967 (comment) that two different commits cannot both be tag
v1.0.0.All six workflows pin
icewind1991/nextcloud-version-matrixtocd0211ffcef1065e2020cd579e4843b8746e7a58, which is tag v1.3.3. The comments next to it disagree: four readv1.3.3.3.1.3.3, two readv1.0.0. For reference,v1.0.0isc2bf575a3516752db5ce2915499d3f694885e2c7and is not used anywhere in this repository.appstore-build-publish.yml# v1.3.3.3.1.3.3lint-php-cs.yml# v1.3.3.3.1.3.3lint-php.yml# v1.0.0phpunit-unit.yml# v1.0.0psalm-matrix.yml# v1.3.3.3.1.3.3update-nextcloud-ocp-matrix.yml# v1.3.3.3.1.3.3All six now read
# v1.3.3. Comments only — the pinned commit is unchanged, so no job behaviour changes.Not bumping to the current
v1.3.4(71959de73c244b11ecbf4503b87c41d65b0f64ae) here, so that this stays a pure comment fix; happy to do that separately if wanted.🤖 AI (if applicable)