Repository navigation
util: Preserve registry ports when splitting image names - #561
Open
snehaapratap wants to merge 1 commit into
Open
snehaapratap wants to merge 1 commit into
snehaapratap wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #560.
split_image_name()currently treats a registry port as a tag separator, and raises ValueError when an explicit image tag adds another colon. Only treat colons after the final slash as a tag separator, then split from the right. Registries with ports, including bracketed IPv6 addresses, now keep their full repository name with either explicit or implicit tags.Adds five doctest examples covering tagged and untagged localhost and IPv6 registries, including
implicit_latest=False. The tagged localhost example failed before the fix.Validation:
./devel/pytest -qpassed all 74 tests (including doctests, Flake8, Pyright and generated-doc checks); source and wheel builds passed on Python 3.12. No live registry was needed for this parser change.AI assistance: implemented and validated with OpenAI Codex.