Skip to content

791 bug irregular forecast when using dynamic b0 - #792

Merged
Rick-Methot-NOAA merged 3 commits into
mainfrom
791-bug-irregular-forecast-when-using-dynamic-b0
Nov 17, 2026
Merged

Rick-Methot-NOAA merged 3 commits into
mainfrom
791-bug-irregular-forecast-when-using-dynamic-b0

Conversation

@Rick-Methot-NOAA

@Rick-Methot-NOAA Rick-Methot-NOAA commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Concisely describe what has been changed/addressed in the pull request.

What tests have been done?

Examine the spawnbio output in the dynamic Bzero section. Find that it now corrects the behavior noted in the issue

Where are the relevant files?

<-- - [x] No test files are required for this pull request. -->

What tests/review still need to be done?

None

Is there an input change for users to Stock Synthesis?

Additional information (optional).

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A critical issue remains: dynamic B0 forecasts with allocation groups can divide zero by zero when fisheries are disabled, producing non-finite allocation multipliers and adjusted catches.

1 open issue
What changed in this PR

This PR addresses #791 by preventing forecast catches from introducing fishing mortality into Stock Synthesis’s dynamic B0 calculations.

Changes:

  • Zero fishing rates and bypass catch tuning when fisheries are disabled.
  • Add conditional comment prefixes to extra standard-deviation reporting settings in generated control files.
  • Clean up formatting without changing the affected predator-mortality logic.
File Description
SS_write.tpl Remove a blank line in dynamic B0 output code.
SS_write_ssnew.tpl Write inactive reporting settings with conditional comment prefixes.
SS_benchfore.tpl Disable fishing rates and catch tuning during dynamic B0 forecasts.

Review effort: Balanced

Comment thread SS_benchfore.tpl Resolved
@Rick-Methot-NOAA
Rick-Methot-NOAA merged commit 94cea41 into main Nov 17, 2026
17 checks passed
@Rick-Methot-NOAA
Rick-Methot-NOAA deleted the 791-bug-irregular-forecast-when-using-dynamic-b0 branch November 17, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: irregular forecast when using dynamic B0

3 participants