Repository navigation
fix(build): eliminate MODULE_TYPELESS_PACKAGE_JSON warning for mkshims - #933
Open
abdul-karim-mia wants to merge 1 commit into
Open
abdul-karim-mia wants to merge 1 commit into
abdul-karim-mia wants to merge 1 commit into
Conversation
Fixes nodejs#930 Since Node.js type-stripping was adopted, running mkshims during yarn build emitted a MODULE_TYPELESS_PACKAGE_JSON warning because module type was not specified in package.json and required reparsing. Renaming mkshims.ts to mkshims.mts and declaring type: module in sources/package.json eliminates the warning without impacting root CommonJS shims in dist. Signed-off-by: Abdul karim mia <97598943+abdul-karim-mia@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #930
Description
When running
yarn buildon modern Node.js versions,node ./mkshims.tsprints a[MODULE_TYPELESS_PACKAGE_JSON]warning:Adding
"type": "module"to rootpackage.jsonwould break the CommonJS shims indist/(which userequire()).This PR resolves the warning cleanly by:
mkshims.tstomkshims.mtsso Node explicitly recognizes it as an ES module."build"script inpackage.jsonto call./mkshims.mts.sources/package.jsondeclaring{"type": "module"}so imported source files insources/(e.g.sources/Engine.ts) are evaluated as ESM without reparsing and without affecting root ordist/.Verification
yarn build: shims generated with 0 warnings.yarn typecheck: 0 errors.yarn lint: 0 errors.